Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip formatting after introduction of PrimeReact #29

Open
jreineckearm opened this issue Oct 1, 2024 · 1 comment
Open

Tooltip formatting after introduction of PrimeReact #29

jreineckearm opened this issue Oct 1, 2024 · 1 comment

Comments

@jreineckearm
Copy link
Contributor

Type: Bug Report

Describe the bug

  • OS and Version: Windows 11 Enterprise
  • VS Code Version: 1.93.1
  • Extension Version: Local build of main at 61550b2
  • Target Device:
  • Other extensions you installed (and if the issue persists after disabling them):
  • A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to register level (not bit field level).
  2. Move the mouse over the register to show the tooltip.

The tooltip seems to be limited to a fixed range.
Longer text items like the 32-bit binary value, but also the Decimal heading see line breaks.

Expected behavior

Before the change, the tooltip box was wide enough to accommodate the above without line breaks. Width presumably dynamically calculated?

Code sample and logs
N/A, use any example

Screenshots

Before PrimeReact introduction
image

After PrimeReact introduction
image

Additional context

@martin-fleck-at
Copy link
Contributor

I believe that has much more to do with the switch from the Tree View API in VS Code to the Web View API. A web view is rendered in an iframe, making the tooltip adhere to the bounds of the iframe. We could make the tooltip bigger but that would introduce scrollbars in our tree and not actually overlap with the other views in VS Code. Unfortunately, I see no way to access the parent window from inside an iframe since VS Code very deliberately removes access to that when loading webviews so attaching the tooltip to the parent window is also not an option. Given that this is a choice made by VS Code, maybe restyling the tooltip a bit to reduce the number of breaks would be a better option, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants