Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The master release doesn't deploy the CycloneDX files #25026

Closed
dmatej opened this issue Jul 4, 2024 · 4 comments · Fixed by #25042
Closed

The master release doesn't deploy the CycloneDX files #25026

dmatej opened this issue Jul 4, 2024 · 4 comments · Fixed by #25042
Assignees
Labels
bug Something isn't working
Milestone

Comments

@dmatej
Copy link
Contributor

dmatej commented Jul 4, 2024

See

Note that in #24997 is another change that might be related in the future. Also I am not sure what are standard rules for this, we should read some docs about it.

@dmatej dmatej added this to the 7.0.16 milestone Jul 4, 2024
@avpinchuk
Copy link
Contributor

One difference between 7.x and 8.x:

7.x:

<version>1.0.8</version>

8.x:

<version>1.0.9</version>

Therefore, the assembly of the GF8 gives us a lot of CycloneDX warnings.

@dmatej
Copy link
Contributor Author

dmatej commented Jul 4, 2024

The fastest profile is used in the release process

  • Because of the parent from Eclipse (1.0.8 vs 1.0.9) results differ between master and 8.0.
  • The CycloneDX significantly slows down depeloper builds with fastest; developers usually don't care about CycloneDX.
  • The target of fastest is to create all deployables asap, so here we have some controversy.

Also developers can have own profiles in settings.xml. Maybe there is a better place to disable the cyclone. Or we need another profile for the release process. However at some point it would be useful to have the OWASP check locally too, but that is different plugin.

Hmmm, they have different targets. Probably the CycloneDX could be executed really just for releases + explicitly.

@dmatej dmatej self-assigned this Jul 4, 2024
@dmatej dmatej added the bug Something isn't working label Jul 4, 2024
@dmatej
Copy link
Contributor Author

dmatej commented Jul 4, 2024

Yet one idea - we can also push the cyclonedx plugin execution to the deploy phase (but it must be executed before the deploy plugin).

@pzygielo
Copy link
Contributor

pzygielo commented Jul 5, 2024

Maybe in release job, where fastest profile is activated, the sbom profile from parent could also be activated explicitly?

@dmatej dmatej changed the title The master release doesn't deploy the CycloneDX files The CycloneDX configuration in parent slows down builds for developers Jul 11, 2024
@dmatej dmatej changed the title The CycloneDX configuration in parent slows down builds for developers The master release doesn't deploy the CycloneDX files Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants