Runtime-Based MicroProfile Config Validation for LSP4MP

Fixes #511

Signed-off-by: azerr <[email protected]>

Author: angelozerr

microprofile.jdt/org.eclipse.lsp4mp.jdt.core/build.properties

@@ -6,5 +6,6 @@ bin.includes = plugin.xml,\
                plugin.properties,\
                schema/,\
                static-properties/,\
-               about.html
+               about.html,\
+               runtimes/
 src.includes = about.html

microprofile.jdt/org.eclipse.lsp4mp.jdt.core/runtimes/smallrye/commons-logging-jboss-logging-1.0.0.Final.jar

@@ -16,28 +16,91 @@
 import java.util.Collections;
 import java.util.List;
 
+import org.eclipse.lsp4j.DiagnosticSeverity;
+
 /**
- * Represents settings used by the MicroProfile JDT component while validating
- * Java class files
+ * Settings controlling how MicroProfile Java diagnostics validate the values of
+ * configuration properties declared in Java sources.
+ * <p>
+ * These settings are specifically used when inspecting annotations such as
+ * {@code @ConfigProperty(defaultValue = "...")}, and when applying
+ * MicroProfile-compatible converters to validate that the provided default
+ * values can be converted to the expected type.
+ * </p>
+ *
+ * <h2>Ignored Properties</h2> The {@link #patterns} list contains a set of
+ * string patterns that match against the <strong>property name</strong>
+ * declared in {@code @ConfigProperty(name = "…")}. If a property name matches
+ * one of these patterns, then its default value is <strong>excluded from
+ * validation</strong>.
+ *
+ * <h2>Diagnostics Severity</h2> {@link #validationValueSeverity} controls the
+ * severity used when reporting validation issues:
+ * <ul>
+ * <li>value not convertible using MicroProfile converters</li>
+ * <li>invalid format (e.g., list, map, boolean, integer, etc.)</li>
+ * <li>other type-related validation problems</li>
+ * </ul>
  *
+ * This enables fine-grained control over how strict the tooling should be when
+ * validating default values defined in Java code.
  */
 public class MicroProfileJavaDiagnosticsSettings {
 
-	public MicroProfileJavaDiagnosticsSettings(List<String> patterns) {
+	/**
+	 * List of patterns used to determine which configuration properties should be
+	 * ignored during value validation.
+	 * <p>
+	 * Each pattern is matched against the {@code name} attribute of
+	 * {@code @ConfigProperty}. If the property name matches any pattern, its
+	 * {@code defaultValue} will not be validated.
+	 * </p>
+	 */
+	private List<String> patterns;
+
+	/**
+	 * The severity level used when reporting validation diagnostics for property
+	 * values that cannot be converted using MicroProfile converters.
+	 */
+	private DiagnosticSeverity validationValueSeverity;
+
+	/**
+	 * Creates new diagnostics settings for validating Java-based MicroProfile
+	 * configuration property values.
+	 *
+	 * @param patterns                the list of patterns applied to the property
+	 *                                name to determine whether its default value
+	 *                                should be excluded from validation (may be
+	 *                                {@code null})
+	 * @param validationValueSeverity the severity to use when reporting invalid
+	 *                                default values
+	 */
+	public MicroProfileJavaDiagnosticsSettings(List<String> patterns, DiagnosticSeverity validationValueSeverity) {
 		this.patterns = patterns;
+		this.validationValueSeverity = validationValueSeverity;
 	}
 
-	private List<String> patterns;
-
 	/**
-	 * Returns a list of patterns representing the properties to ignore validation
-	 * when adding diagnostics for properties without values.
+	 * Returns the list of patterns used to disable validation for certain
+	 * configuration property names.
+	 * <p>
+	 * If the list is {@code null}, an empty list is returned.
+	 * </p>
 	 *
-	 * @return a list of patterns representing the properties to ignore validation
-	 *         when adding diagnostics for properties without values.
+	 * @return an unmodifiable list of patterns determining which property names
+	 *         should be excluded from validation
 	 */
 	public List<String> getPatterns() {
 		return patterns == null ? Collections.emptyList() : this.patterns;
 	}
 
+	/**
+	 * Returns the severity level to use when reporting diagnostics for invalid
+	 * configuration property values.
+	 *
+	 * @return the severity used for reporting value validation errors
+	 */
+	public DiagnosticSeverity getValidationValueSeverity() {
+		return validationValueSeverity;
+	}
 }

microprofile.jdt/org.eclipse.lsp4mp.jdt.core/runtimes/smallrye/jboss-logging-3.6.1.Final.jar

@@ -14,6 +14,7 @@
 package org.eclipse.lsp4mp.commons;
 
 import java.util.Collections;
+import java.util.Set;
 
 import org.eclipse.lsp4mp.commons.metadata.ConfigurationMetadata;
 
@@ -37,6 +38,8 @@ public class MicroProfileProjectInfo extends ConfigurationMetadata {
 	private String projectURI;
 
 	private ClasspathKind classpathKind;
+	
+	private Set<String> classpath;
 
 	/**
 	 * Returns the project URI.
@@ -74,4 +77,11 @@ public void setClasspathKind(ClasspathKind classpathKind) {
 		this.classpathKind = classpathKind;
 	}
 
+	public Set<String> getClasspath() {
+		return classpath;
+	}
+	
+	public void setClasspath(Set<String> classpath) {
+		this.classpath = classpath;
+	}
 }