Merge pull request #576 from Rahul-Sutariya/rasu_gatewayapp_registereventreceivehandlercallback_and_coverage

feat(gateway): Enable GatewayApplication::RegisterEventReceiveHandler and coverage

Author: castler

score/mw/com/gateway/gateway_application/BUILD

@@ -91,8 +91,26 @@ cc_unit_test(
         ":gateway_error",
         "//score/mw/com/gateway/gateway_application/configuration:gateway_configuration",
         "//score/mw/com/gateway/transport_layer:transport_mock",
+        "//score/mw/com/impl:find_service_handle",
+        "//score/mw/com/impl:find_service_handler",
+        "//score/mw/com/impl:handle_type",
+        "//score/mw/com/impl:instance_identifier",
         "//score/mw/com/impl:instance_specifier",
+        "//score/mw/com/impl:runtime_mock",
+        "//score/mw/com/impl:scoped_event_receive_handler",
+        "//score/mw/com/impl:service_discovery_client_mock",
+        "//score/mw/com/impl:service_discovery_mock",
         "//score/mw/com/impl:service_element_type",
+        "//score/mw/com/impl:subscription_state",
+        "//score/mw/com/impl/bindings/mock_binding",
+        "//score/mw/com/impl/bindings/mock_binding:generic_skeleton_event",
+        "//score/mw/com/impl/configuration:lola_service_instance_deployment",
+        "//score/mw/com/impl/plumbing:generic_skeleton_event_binding_factory",
+        "//score/mw/com/impl/plumbing:generic_skeleton_event_binding_factory_mock",
+        "//score/mw/com/impl/plumbing:skeleton_binding_factory_mock",
+        "//score/mw/com/impl/test:binding_factory_resources",
+        "//score/mw/com/impl/test:dummy_instance_identifier_builder",
+        "//score/mw/com/impl/test:runtime_mock_guard",
         "@googletest//:gtest",
         "@score_baselibs//score/result",
     ],

score/mw/com/gateway/gateway_application/gateway_application.cpp

@@ -223,26 +223,30 @@ void GatewayApplication::RegisterEventReceiveHandlerCallback(impl::GenericSkelet
                                                              const std::string& specifier_str,
                                                              const std::string& event_name)
 {
-    // TODO: GenericSkeletonEvent::SetReceiveHandlerNotificationCallback is not yet available in the OSS impl.
-    // Once available, remove the (void) suppressions below and uncomment the implementation block.
-    (void)skeleton;
-    (void)specifier_str;
-    (void)event_name;
-
-    // using NotificationCallback = safecpp::MoveOnlyScopedFunction<void(bool)>;
-    // auto scoped_callback = std::make_shared<NotificationCallback>(
-    //     scope_, [this, specifier = specifier_str, event = event_name](bool has_subscribers) {
-    //         OnSubscriptionStateChanged(specifier, event, has_subscribers);
-    //     });
-    //
-    // auto result = skeleton.SetReceiveHandlerNotificationCallback(
-    //     event_name, [scoped_callback](bool has_subscribers) { (*scoped_callback)(has_subscribers); });
-    //
-    // if (!result.has_value())
-    // {
-    //     score::mw::log::LogError() << "GatewayApplication: Failed to set subscription callback for "
-    //                                << event_name << " of " << specifier_str;
-    // }
+    using NotificationCallback = safecpp::MoveOnlyScopedFunction<void(bool)>;
+    auto scoped_callback = std::make_shared<NotificationCallback>(
+        scope_, [this, specifier = specifier_str, event = event_name](bool has_subscribers) {
+            OnSubscriptionStateChanged(specifier, event, has_subscribers);
+        });
+
+    auto event_map = skeleton.GetEvents();
+    auto event_it = event_map.find(event_name);
+    if (event_it == event_map.cend())
+    {
+        score::mw::log::LogError() << "GatewayApplication: Event " << event_name << " not found in skeleton for "
+                                   << specifier_str;
+        return;
+    }
+
+    auto result = event_it->second.SetReceiveHandlerRegistrationChangedHandler([scoped_callback](bool has_subscribers) {
+        (*scoped_callback)(has_subscribers);
+    });
+
+    if (!result.has_value())
+    {
+        score::mw::log::LogError() << "GatewayApplication: Failed to set subscription callback for " << event_name
+                                   << " of " << specifier_str;
+    }
 }
 
 void GatewayApplication::OnSubscriptionStateChanged(const std::string& specifier_str,

score/mw/com/gateway/gateway_application/gateway_application.h

@@ -101,6 +101,11 @@ class GatewayApplication : public GatewayCore
                                     bool has_subscribers);
     void ReRegisterActiveEventSubscriptions(const std::string& specifier_str);
 
+    // Test-only: grant unit-test fixtures access to private members and methods.
+    friend class GatewayApplicationSubscriptionTest;
+    friend class GatewayApplicationRegisterCallbackTest;
+    friend class GatewayApplicationFlowTest;
+
     // Intentionally putting the scope as the last member, so that it gets destroyed first and thus all callbacks get
     // invalidated before any other member gets destroyed.
     safecpp::Scope<> scope_;