Skip to content

Siteplan export to pdf#1307

Merged
mariusheine merged 13 commits intomainfrom
lageplan-export-to-pdf
Feb 5, 2025
Merged

Siteplan export to pdf#1307
mariusheine merged 13 commits intomainfrom
lageplan-export-to-pdf

Conversation

@TruongQuangSB
Copy link
Contributor

@TruongQuangSB TruongQuangSB commented Feb 3, 2025

  • The PR Siteplan export to Image #1306 is change in Javascript/Typescript
  • Reviewer can review both Part in this commit or separate, but should only merge this PR

@github-actions

This comment has been minimized.

@TruongQuangSB TruongQuangSB changed the title Lageplan export to pdf Siteplan export to pdf Feb 4, 2025
@TruongQuangSB TruongQuangSB force-pushed the lageplan-export-to-pdf branch from c54dec4 to 29c6ec4 Compare February 4, 2025 09:51
@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Feb 4, 2025

Test Results

121 tests  ±0   121 ✅ ±0   13s ⏱️ -1s
 28 suites ±0     0 💤 ±0 
 28 files   ±0     0 ❌ ±0 

Results for commit 9d92382. ± Comparison against base commit 3675c8d.

This pull request removes 9 and adds 9 tests. Note that renamed tests count towards both.
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[1] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@3e84111a
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[2] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@6ab7ce48
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[3] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@43f0c2d1
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[4] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@5fb65013
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[5] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@38a1a26
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[1] TestData [input=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@69d667a5, expected=multi/container-id/element-id]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[2] TestData [input=org.eclipse.set.model.planpro.Signale.impl.SignalImpl@7fe87c0e, expected=multi/456/123]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKeyOther(TestData)[1] TestData [input=Pair [first=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@23469199, second=other], expected=multi/container-id/element-id/other=other]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKeyOther(TestData)[2] TestData [input=Pair [first=org.eclipse.set.model.planpro.Signale.impl.SignalImpl@1b60d324, second=xxx], expected=multi/456/123/other=xxx]
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[1] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@446c3920
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[2] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@7cb8437d
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[3] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@41f4fe5
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[4] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@15f8701f
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[5] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@514cd540
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[1] TestData [input=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@271e851e, expected=multi/container-id/element-id]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[2] TestData [input=org.eclipse.set.model.planpro.Signale.impl.SignalImpl@ff21443, expected=multi/456/123]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKeyOther(TestData)[1] TestData [input=Pair [first=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@41938e1e, second=other], expected=multi/container-id/element-id/other=other]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKeyOther(TestData)[2] TestData [input=Pair [first=org.eclipse.set.model.planpro.Signale.impl.SignalImpl@401926df, second=xxx], expected=multi/456/123/other=xxx]

♻️ This comment has been updated with latest results.

@github-actions

This comment has been minimized.

@TruongQuangSB
Copy link
Contributor Author

/request-license-review

@github-actions

This comment has been minimized.

@TruongQuangSB TruongQuangSB marked this pull request as ready for review February 5, 2025 10:24
@github-actions

This comment has been minimized.

@mariusheine
Copy link
Contributor

@TruongQuangSB Have you written all the XSL related stuff by yourself or is there some generator on basis of the siteplan_template.xsl?

@TruongQuangSB
Copy link
Contributor Author

TruongQuangSB commented Feb 5, 2025

@TruongQuangSB Have you written all the XSL related stuff by yourself or is there some generator on basis of the siteplan_template.xsl?

y, this was writed manual and have some copied from table_template.xsl, common.xsl

@TruongQuangSB
Copy link
Contributor Author

@TruongQuangSB Have you written all the XSL related stuff by yourself or is there some generator on basis of the siteplan_template.xsl?

ah, i have wrong understand. The XSL will be generator on basis of the siteplan_template, see package org.eclipse.set.utils.export.xsl.siteplan

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

TruongQuangSB and others added 2 commits February 5, 2025 16:20
Co-authored-by: Marius Heine <m.heine@geprog.com>
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Feb 5, 2025

License summary

❌ Not yet vetted dependencies:

Dependency License Status Ticket
npm/npmjs/-/eslint/9.19.0 MIT AND (LGPL-2.0-or-later AND MIT) AND ISC AND OFL-1.1 AND CC-BY-SA-2.0 AND BSD-3-Clause AND (LicenseRef-scancode-proprietary-license AND MIT) restricted #19293
npm/npmjs/-/ol/10.4.0 BSD-2-Clause AND (BSD-2-Clause AND LicenseRef-scancode-free-unknown) AND MIT AND Apache-2.0 AND (LicenseRef-scancode-proprietary-license AND ODbL-1.0) AND ODbL-1.0 AND CC-BY-4.0 AND LicenseRef-scancode-proprietary-license AND OGC-1.0 AND (CC-BY-SA-2.0 AND CC-BY-SA-3.0) AND (BSD-2-Clause AND CC-BY-3.0 AND MIT) AND LicenseRef-scancode-softsurfer AND (CC-BY-SA-4.0 AND LicenseRef-scancode-proprietary-license AND OGC-1.0) restricted #19302
  • Committers can request a license review via by commenting /request-license-review.
  • After all reviews have concluded, Committers can re-run the license-vetting check by commenting /license-check

Workflow run (with attached summary files):
https://github.com/eclipse-set/set/actions/runs/13166940745

@mariusheine mariusheine merged commit fe3050f into main Feb 5, 2025
13 of 15 checks passed
@mariusheine mariusheine deleted the lageplan-export-to-pdf branch February 5, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants