Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a lot of dead code from the previous layout engine #3677

Closed
gcoutable opened this issue Jun 28, 2024 · 0 comments · Fixed by #3800
Closed

Remove a lot of dead code from the previous layout engine #3677

gcoutable opened this issue Jun 28, 2024 · 0 comments · Fixed by #3800

Comments

@gcoutable
Copy link
Member

No description provided.

@gcoutable gcoutable added this to the 2024.7.0 milestone Jun 28, 2024
@gcoutable gcoutable self-assigned this Jun 28, 2024
@gcoutable gcoutable modified the milestones: 2024.7.0, 2024.9.0 Jul 11, 2024
gcoutable added a commit that referenced this issue Jul 19, 2024
gcoutable added a commit that referenced this issue Jul 19, 2024
@gcoutable gcoutable linked a pull request Jul 22, 2024 that will close this issue
39 tasks
gcoutable added a commit that referenced this issue Jul 23, 2024
gcoutable added a commit that referenced this issue Jul 23, 2024
Bug: #3677
Signed-off-by: Guillaume Coutable <[email protected]>
gcoutable added a commit that referenced this issue Aug 7, 2024
The purpose here was to try to send requests (thanks to a webclient) to another service from within a subscription with request scope.
From a subscription try to access to RequestContextHolder.getRequestAttributes()

This is very complicated (impossible ?).

This commit contains the work pushed as far as I was capable at the time I made it.
It intends to put calls of ProjectSearchService in a RequestScope, thus, to put calls to it in an execution service that transmit the request scope of the local thread to the editing context thread.
See: DelegatingRequestContextExecutorService and DelegatingRequestContextRunnable
NOTE: Adding the annotation @requestScope to ProjectSearchService helped to find where to execute things within an execution service.

Thanks to a Handshake interceptor, I try to get the request attribute from the handshake request to reuse them later when the backed receives a websocket message.
The purpose is to try to put the message handling in a request scope.
But, at the time we reuse the request attributes at the message handling, the handshake request is not available anymore, it has been finished.
So that did not work :'(

NOTE: This commit also contains some frontend change to deactivate some subscription that are made outside the editing context to ease the comprehension of the issue

Bug: #3677
Signed-off-by: Guillaume Coutable <[email protected]>
gcoutable added a commit that referenced this issue Aug 7, 2024
gcoutable added a commit that referenced this issue Aug 7, 2024
gcoutable added a commit that referenced this issue Aug 8, 2024
gcoutable added a commit that referenced this issue Aug 8, 2024
@gcoutable gcoutable modified the milestones: 2024.9.0, 2024.11.0 Sep 16, 2024
gcoutable added a commit that referenced this issue Sep 16, 2024
gcoutable added a commit that referenced this issue Sep 16, 2024
sbegaudeau pushed a commit that referenced this issue Sep 23, 2024
sbegaudeau pushed a commit that referenced this issue Sep 23, 2024
sbegaudeau pushed a commit that referenced this issue Sep 23, 2024
sbegaudeau pushed a commit that referenced this issue Sep 23, 2024
sbegaudeau pushed a commit that referenced this issue Sep 23, 2024
sbegaudeau pushed a commit that referenced this issue Sep 23, 2024
sbegaudeau pushed a commit that referenced this issue Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant