-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove a lot of dead code from the previous layout engine #3677
Comments
gcoutable
added a commit
that referenced
this issue
Jul 19, 2024
Bug: #3677 Signed-off-by: Guillaume Coutable <[email protected]>
gcoutable
added a commit
that referenced
this issue
Jul 19, 2024
Bug: #3677 Signed-off-by: Guillaume Coutable <[email protected]>
39 tasks
gcoutable
added a commit
that referenced
this issue
Jul 23, 2024
Bug: #3677 Signed-off-by: Guillaume Coutable <[email protected]>
gcoutable
added a commit
that referenced
this issue
Jul 23, 2024
Bug: #3677 Signed-off-by: Guillaume Coutable <[email protected]>
gcoutable
added a commit
that referenced
this issue
Aug 7, 2024
The purpose here was to try to send requests (thanks to a webclient) to another service from within a subscription with request scope. From a subscription try to access to RequestContextHolder.getRequestAttributes() This is very complicated (impossible ?). This commit contains the work pushed as far as I was capable at the time I made it. It intends to put calls of ProjectSearchService in a RequestScope, thus, to put calls to it in an execution service that transmit the request scope of the local thread to the editing context thread. See: DelegatingRequestContextExecutorService and DelegatingRequestContextRunnable NOTE: Adding the annotation @requestScope to ProjectSearchService helped to find where to execute things within an execution service. Thanks to a Handshake interceptor, I try to get the request attribute from the handshake request to reuse them later when the backed receives a websocket message. The purpose is to try to put the message handling in a request scope. But, at the time we reuse the request attributes at the message handling, the handshake request is not available anymore, it has been finished. So that did not work :'( NOTE: This commit also contains some frontend change to deactivate some subscription that are made outside the editing context to ease the comprehension of the issue Bug: #3677 Signed-off-by: Guillaume Coutable <[email protected]>
gcoutable
added a commit
that referenced
this issue
Aug 7, 2024
Bug: #3677 Signed-off-by: Guillaume Coutable <[email protected]>
gcoutable
added a commit
that referenced
this issue
Aug 7, 2024
Bug: #3677 Signed-off-by: Guillaume Coutable <[email protected]>
gcoutable
added a commit
that referenced
this issue
Aug 8, 2024
Bug: #3677 Signed-off-by: Guillaume Coutable <[email protected]>
gcoutable
added a commit
that referenced
this issue
Aug 8, 2024
Bug: #3677 Signed-off-by: Guillaume Coutable <[email protected]>
gcoutable
added a commit
that referenced
this issue
Sep 16, 2024
Bug: #3677 Signed-off-by: Guillaume Coutable <[email protected]>
gcoutable
added a commit
that referenced
this issue
Sep 16, 2024
Bug: #3677 Signed-off-by: Guillaume Coutable <[email protected]>
sbegaudeau
pushed a commit
that referenced
this issue
Sep 23, 2024
Bug: #3677 Signed-off-by: Guillaume Coutable <[email protected]>
sbegaudeau
pushed a commit
that referenced
this issue
Sep 23, 2024
Bug: #3677 Signed-off-by: Guillaume Coutable <[email protected]>
sbegaudeau
pushed a commit
that referenced
this issue
Sep 23, 2024
Bug: #3677 Signed-off-by: Guillaume Coutable <[email protected]>
sbegaudeau
pushed a commit
that referenced
this issue
Sep 23, 2024
Bug: #3677 Signed-off-by: Guillaume Coutable <[email protected]>
sbegaudeau
pushed a commit
that referenced
this issue
Sep 23, 2024
Bug: #3677 Signed-off-by: Guillaume Coutable <[email protected]>
sbegaudeau
pushed a commit
that referenced
this issue
Sep 23, 2024
Bug: #3677 Signed-off-by: Guillaume Coutable <[email protected]>
sbegaudeau
pushed a commit
that referenced
this issue
Sep 23, 2024
Bug: #3677 Signed-off-by: Guillaume Coutable <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: