Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No Window Icon #288

Open
tsmaeder opened this issue Jul 28, 2023 · 1 comment · Fixed by #321
Open

No Window Icon #288

tsmaeder opened this issue Jul 28, 2023 · 1 comment · Fixed by #321
Assignees
@jfaltermeier
Labels
bug bugs found in the application

Comments

@tsmaeder
Copy link
Contributor

Bug Description:

Theia Blueprint does not have an icon (Application icon) on the top left corner on Windows. This works in the Electron example project in Theia.

Additional Information

  • Operating System: Win 11
  • Theia Version: 1.39.0
@tsmaeder tsmaeder added the bug bugs found in the application label Jul 28, 2023
@JonasHelming
Copy link
Contributor

At the same time we should also add a favicon: eclipse-theia/theia#3600 (comment)

jfaltermeier added a commit that referenced this issue Dec 7, 2023
@jfaltermeier
Add Window Icon #288
0fe02cd
jfaltermeier added a commit that referenced this issue Dec 14, 2023
@jfaltermeier
Add Window Icon #288
862f7c9
jfaltermeier added a commit that referenced this issue Dec 18, 2023
@jfaltermeier
Add Window Icon #288
4e170a8 
Contributed on behalf of STMicroelectronics

Signed-off-by: Johannes Faltermeier <[email protected]>
jfaltermeier added a commit that referenced this issue Dec 22, 2023
@jfaltermeier
Add Window Icon #288
30fd200 
Contributed on behalf of STMicroelectronics

Signed-off-by: Johannes Faltermeier <[email protected]>
@jfaltermeier jfaltermeier mentioned this issue Dec 22, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfaltermeier jfaltermeier

Labels
bug bugs found in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Theia IDE Rebrand and Theia 1.45.0 eclipse-theia/theia-blueprint
3 participants
@JonasHelming @jfaltermeier @tsmaeder