Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preloadTemplate produces invalid HTML #319

Open
danepowell opened this issue Dec 14, 2023 · 0 comments
Open

preloadTemplate produces invalid HTML #319

danepowell opened this issue Dec 14, 2023 · 0 comments

Comments

@danepowell
Copy link
Contributor

danepowell commented Dec 14, 2023 •
edited
Loading

Bug Description:

After building, the file applications/browser/src-gen/frontend/index.html contains invalid HTML:

<!DOCTYPE html>
<html lang="en">

<head>
  <meta charset="UTF-8">
  <meta name="viewport" content="width=device-width, initial-scale=1">
  <meta name="apple-mobile-web-app-capable" content="yes">
  <title>Theia Blueprint</title>
</head>

<body>
    <div class="theia-preload"><!DOCTYPE html>
<html lang="en">

<head>
    <style>

Steps to Reproduce:

  1. Run yarn && yarn build:dev

Additional Information

When the preloadTemplate feature was added, it pretty explicitly only allowed users to insert additional HTML, not replace the existing HTML: eclipse-theia/theia#4232

However, when the preload spinner was added in #73 this got misinterpreted and every existing example of preload.html I can find is a standalone HTML page, which gets injected incorrectly into index.html.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danepowell