Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show parameters of current display #135

Open
colin-grant-work opened this issue Oct 12, 2021 · 1 comment
Open

Show parameters of current display #135

colin-grant-work opened this issue Oct 12, 2021 · 1 comment

Comments

@colin-grant-work
Copy link
Contributor

Context: currently, the only indication of the parameters with which the current display was fetched is the actual values of the configuration inputs (address, offset, length). If the user changes those values and either doesn't try to fetch memory or tries and fails, the display is not updated, and we lose the connection between the inputs and the current state of the display. It would be desirable to display the parameters used for the current state of the table apart from the inputs so that the user can always tell what context the data displayed comes from.

Maybe an alternative would be to add some information to the table display indicating the parameters with which the data displayed was fetched. That would at least address the potential for confusion.

I personally like this idea. Since it might require a little bit of UI re-design maybe it's better left for a separate PR if that's OK with you.

Originally posted by @federicobozzini in #132 (comment)

@federicobozzini
Copy link
Contributor

@colin-grant-work another idea for this issue.

How would you feel about moving the search area outside of the tab?

At the moment a user needs to click on the top-right button to create a new memory tab, then perform a search. Maybe we could just put the search parameters at the top of the panel and the user would only need to perform a search to get a new tab created. If the search is successful and the tab is correctly created we might show there the parameters used for the search in the new tab, which would be only updatable when navigating the memory using the Load more buttons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants