Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blueprint: revisit download links #236

Open
vince-fugnitto opened this issue Nov 11, 2021 · 7 comments
Open

blueprint: revisit download links #236

vince-fugnitto opened this issue Nov 11, 2021 · 7 comments
Labels
help wanted Extra attention is needed

Comments

@vince-fugnitto
Copy link
Member

Description

We should revisit the download links for blueprint documented in the website, to rather point to the direct location where users can download the different types of downloads available per operating system. At the moment the download links assumes which type of download the user wants, and other formats are not discoverable (ex: appimage vs deb).

New links:

Existing links:

  • <td><a href="https://www.eclipse.org/downloads/download.php?file=/theia/latest/windows/TheiaBlueprint.exe&r=1" download>Download latest</a></td>
    <td><a href="https://www.eclipse.org/downloads/download.php?file=/theia/latest/linux/TheiaBlueprint.AppImage&r=1" download>Download latest</a></td>
    <td><a href="https://www.eclipse.org/downloads/download.php?file=/theia/latest/macos/TheiaBlueprint.dmg&r=1" download>Download latest</a></td>
@vince-fugnitto vince-fugnitto added the help wanted Extra attention is needed label Nov 11, 2021
@JonasHelming
Copy link
Contributor

@jfaltermeier

@jfaltermeier
Copy link
Contributor

I believe that with the new links, we might lose download stats: https://wiki.eclipse.org/Project_Download_Stats
As far as I know the direct links bypass the mirror mechanism. I've downloaded some older files now using above links and will check whether stats were recorded.

@JonasHelming
Copy link
Contributor

If we only have a variant for Linux, we could also explcitly add the variant using the old link format

@brianking
Copy link

I'd argue preserving download counts for all versions is important moving forward.

@jfaltermeier
Copy link
Contributor

FYI I've checked and can confirm that the stats were not recorded using https://download.eclipse.org/theia/latest/linux/ directly.

@brianking
Copy link

brianking commented Nov 19, 2021

This seems to be also an issue for Windows and Mac users, i.e. there is more than one download.

Linux:

  • TheiaBlueprint.AppImage | 191.5M | 2021-11-16 10:01
  • TheiaBlueprint.deb | 140.6M | 2021-11-16 10:01

Mac:

  • TheiaBlueprint-1.19.0-mac.zip | 189.7M | 2021-11-16 10:11
  • TheiaBlueprint.dmg | 186.5M | 2021-11-16 10:11

Windows:

  • TheiaBlueprint-1.19.0.exe | 157.1M | 2021-11-16 09:59
  • TheiaBlueprint.exe | 157.1M | 2021-11-16 09:59
  1. Is it absolutely necessary to have more then one version for each platform? The Windows installers look the same just different names.
  2. I propose we keep the links in the existing format to keep the download stats, and if necessary add a second such link for each platform and distinguish them with correct labeling.
  3. Is the version number necessary in the file names? It increases the maintenance of linking to them directly

@jfaltermeier
Copy link
Contributor

For Mac and Windows the additional files are only required for updating older clients.
For Mac the updates are downloaded as a zip and the dmg updates accordingly.
For Windows the .exe needs to have a unique name, because of this bug in the framework we are using: electron-userland/electron-builder#4711 So this is indeed the same file with a different name. This duplication only appears under the latest directory, because updates are fetched from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants