-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In TheiaIDE the "Plugins" items are not unwrap in a multi-module MAVEN JAVA project #14390
Comments
TheiaIDE_maven_plugins.mp4 |
I think it's related to this error |
Which Maven extension do you use? |
I feel like this is a duplicate of a known problem, but I cannot find the respective issue (maybe it was already closed). The issue has nothing to do with maven or really anything to do with the VS Code extension at all. When repopulating a plugin tree view, we don't store whether the nodes have already been expanded. Since expanding the tree node automatically attempts to fetch new results, the tree is reloaded and all data is discarded, leading to the observed behavior. @tsmaeder Do you remember that issue? |
@msujew sorry, no 🤷 |
I seems that when we fetch the children of the "plugins" node, we get a |
@tsmaeder I believe that our tree widget system can handle this, as the explorer already does something similar. However, in the explorer, we only ever calculate a delta (i.e. which nodes to add) and not a full rebuild of the tree. Our tree view plugins API likely should cache all unaffected nodes instead of recomputing them. |
Fixes eclipse-theia#14390 Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <[email protected]>
Bug Description:
In TheiaIDE the "Plugins" items are not unwrap in a multi-module MAVEN JAVA project
Section MAVEN has items
If you try to open "Plugins", all items collapse to the root. Item "Plugins" not work in Parent-project and Sub-project. Other items unwrap normally.
Steps to Reproduce:
Additional Information
The text was updated successfully, but these errors were encountered: