Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick File Open fails to show any file that isn't listed as recent #14803

Closed
planger opened this issue Jan 31, 2025 · 8 comments
Closed

Quick File Open fails to show any file that isn't listed as recent #14803

planger opened this issue Jan 31, 2025 · 8 comments
Labels
bug bugs found in the application

Comments

@planger
Copy link
Contributor

planger commented Jan 31, 2025

Bug Description:

Steps to Reproduce:

  1. Hit Ctrl-p to open quick file open: Recent files show up
  2. Start typing any character: the list vanishes and no file matches are shown even though there would be matching files

Expected result: all non-ignored files with the entered character are shown instead of an empty list

Notes:
If you hit Ctrl-p again to include hidden files, all seems to work fine.
So it may have to do with the file search service failing to provide results if hidden or ignored files shall be filtered.
https://github.com/eclipse-theia/theia/blob/master/packages/file-search/src/browser/quick-file-open.ts#L223

I'm certain this is a regression with 1.58.0 and worked fine on master before the release.

Screencast.from.2025-01-31.14.42.06.webm

Additional Information

  • Operating System: Ubuntu 22.04
  • Theia Version: 1.58.0
@planger planger added the bug bugs found in the application label Jan 31, 2025
@msujew
Copy link
Member

msujew commented Jan 31, 2025

Possibly a regression from #14365.

Edit: Nevermind, it's unrelated. Possibly a regression from #14737?

@JonasHelming
Copy link
Contributor

@tsmaeder ?

@tsmaeder
Copy link
Contributor

tsmaeder commented Feb 4, 2025

I can't reproduce this on Windows.

@tsmaeder
Copy link
Contributor

tsmaeder commented Feb 4, 2025

@planger works fine for me on Ubuntu 22.04, as well (Electron). Also browser version on Windows.

@planger
Copy link
Contributor Author

planger commented Feb 4, 2025

Thanks for testing! I retested this now in more detail. It looks like for the workspace I am using I get the following error:

2025-02-04T09:34:20.323Z root ERROR Failed to search: file:///home/philip/Git/OpenSource/openai-prompt-flow-boilerplate Error: "/home/philip/Git/OpenSource/Theia/theia/examples/browser/lib/backend/native/rg" exited with code: 1
    at ChildProcess.<anonymous> (/home/philip/Git/OpenSource/Theia/theia/examples/browser/lib/backend/main.js:11461:28)
    at ChildProcess.emit (node:events:519:28)
    at ChildProcess._handle.onexit (node:internal/child_process:294:12)

For other workspaces, file search seems to work fine. Not sure what the issue with this workspace is.

@tsmaeder
Copy link
Contributor

tsmaeder commented Feb 4, 2025

@planger does Theia IDE work on the exact same workspace?

@tsmaeder
Copy link
Contributor

tsmaeder commented Feb 4, 2025

I cloned https://github.com/eclipsesource/openai-prompt-flow-boilerplate and still can't reproduce. @planger I guess you'll have to generate some data on your machine to get to the bottom of this.

@planger
Copy link
Contributor Author

planger commented Feb 4, 2025

Thank you again for investigating! It turns out that there is something broken in this specific workspace. I cleaned it and now it works again. Sorry for the confusion!

@planger planger closed this as completed Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application
Projects
None yet
Development

No branches or pull requests

4 participants