Can't build with newer Theia - fails on @types/chai

[marcdumais-work]

I tried locally to remove the Theia extensions from yarn.lock so the latest next would be pulled. After doing that, the repo would not build any more.

The strange thing is that the reported errors are from code under node_module, which I would normally expect to be ignored. I guess we did not see this before because @types/chai was not pulled by Theia as a dependency; it was added as part of the Test API PR.

> [email protected] copy-driver-definition /opt/ericsson-dev/vscode-builtin-extensions/vscode/test/automation
> node tools/copy-driver-definition.js

../../../node_modules/@types/chai/index.d.ts:122:9 - error TS8020: JSDoc types can only be used inside documentation comments.

122         any?, // actual value
            ~~~~


../../../node_modules/@types/chai/index.d.ts:123:9 - error TS8020: JSDoc types can only be used inside documentation comments.

123         boolean? // showDiff
            ~~~~~~~~


../../../node_modules/@types/chai/index.d.ts:127:16 - error TS2370: A rest parameter must be of an array type.

127         assert(...args: AssertionArgs): void;
                   ~~~~~~~~~~~~~~~~~~~~~~


npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! [email protected] compile: `npm run copy-driver && npm run copy-driver-definition && tsc`
npm ERR! Exit status 2
npm ERR! 
npm ERR! Failed at the [email protected] compile script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/lmcmcds/.npm/_logs/2020-01-28T12_09_04_662Z-debug.log
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

[tsmaeder]

I think #54 would fix this.

[marcdumais-work]

This is no longer an issue.