Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflows: enable CI for PRs #84

Open
marcdumais-work opened this issue Jul 22, 2021 · 1 comment
Open

Workflows: enable CI for PRs #84

marcdumais-work opened this issue Jul 22, 2021 · 1 comment
Labels
ci issues related to ci and workflows enhancement New feature or request good first issue Good for newcomers

Comments

@marcdumais-work
Copy link
Contributor

ATM our two main workflows (1) are triggered by two things:

  • nightly cron job
  • whenever we merge something to branch master

It would be valuable to have these workflows run for PRs too, except for the publishing part.

(1) https://github.com/eclipse-theia/vscode-builtin-extensions/blob/master/.github/workflows/publish-vsx-latest.yml
and https://github.com/eclipse-theia/vscode-builtin-extensions/blob/master/.github/workflows/publish-vsx-next.yml

@marcdumais-work marcdumais-work added enhancement New feature or request good first issue Good for newcomers ci issues related to ci and workflows labels Jul 22, 2021
@marcdumais-work
Copy link
Contributor Author

marcdumais-work commented Jul 22, 2021

Example on how to make publishing conditional, so it happens only for merges on master:
https://github.com/eclipse-theia/theia/blob/master/.github/workflows/build.yml#L76

I think we want only the first part here, since we want to publish nightly, contrary to upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci issues related to ci and workflows enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant