Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Methods with any return type always match #25

Open
sgraband opened this issue May 25, 2022 · 0 comments
Open

Methods with any return type always match #25

sgraband opened this issue May 25, 2022 · 0 comments

Comments

@sgraband
Copy link
Contributor

If a method returns any it will always match. If this is also true for other occurences like parameters needs to be investigated.

This was noticed, as Thenables are interpreted as any and all the methods that returned Thenables are flagged as matches.
Changing the return type of the methods to any also produced a match.

After a real quick test it seems like the return type and parameter types are often not parsed correctly, or even not parsed at all.

For example:
saveCustomDocument(document: T, cancellation: CancellationToken): Thenable<void>;
and
saveCustomDocument(document: number, cancellation: number): number;
matches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant