fix: mandatory component selection on create (#265)

dennismeister93 · web-flow · commit 1b4d85574bbf · 2024-05-15T13:48:20.000+02:00
* fix: mandatory component selection on create

Signed-off-by: Dennis Meister &lt;dennis.meister@bosch.com&gt;


---------

Signed-off-by: Dennis Meister &lt;dennis.meister@bosch.com&gt;
diff --git a/src/commands/create/index.ts b/src/commands/create/index.ts
@@ -201,7 +201,12 @@ export default class Create extends Command {
             corePromptResult.appName,
             corePromptResult.example,
             appManifestInterfaceAttributes,
-            packageIndex.getMandatoryExtensionsByCoreId(corePromptResult.chosenCore.id).map((ext: ExtensionComponent) => ext.id),
+            [
+                ...(corePromptResult.example
+                    ? packageIndex.getMandatoryExtensionsByExampleForCore(corePromptResult.chosenCore.id, corePromptResult.appName)
+                    : []),
+                ...packageIndex.getMandatoryExtensionsByCoreId(corePromptResult.chosenCore.id).map((ext: ExtensionComponent) => ext.id),
+            ],
         );
         return createData;
     }
diff --git a/testbench/test-create/vehicle-app-template/package-index.json b/testbench/test-create/vehicle-app-template/package-index.json
@@ -106,6 +106,17 @@
                         ]
                     }
                 ]
+            },
+            {
+                "id": "devcontainer-setup-java",
+                "type": "extension",
+                "name": "devContainer Setup uProtocol Java",
+                "description": "VSCode devContainer setup for uProtocol Java applications",
+                "mandatory": true,
+                "compatibleCores": [
+                    "uprotocol-core-java"
+                ],
+                "parameters": []
             }
         ]
     },
@@ -136,7 +147,7 @@
                     {
                         "id": "src",
                         "description": "URI or path to VSS json",
-                        "default": "https://github.com/COVESA/vehicle_signal_specification/releases/download/v3.0/vss_rel_3.0.json",
+                        "default": "https://github.com/COVESA/vehicle_signal_specification/releases/download/v4.0/vss_rel_4.0.json",
                         "required": true,
                         "type": "string"
                     },
diff --git a/testbench/test-exec/app/AppManifest.json b/testbench/test-exec/app/AppManifest.json
@@ -5,7 +5,7 @@
         {
             "type": "vehicle-signal-interface",
             "config": {
-                "src": "https://github.com/COVESA/vehicle_signal_specification/releases/download/v3.0/vss_rel_3.0.json",
+                "src": "https://github.com/COVESA/vehicle_signal_specification/releases/download/v4.0/vss_rel_4.0.json",
                 "datapoints": {
                     "required": [
                         {
diff --git a/testbench/test-init/.velocitasLegacy.json b/testbench/test-init/.velocitasLegacy.json
@@ -2,19 +2,19 @@
     "packages": [
         {
             "repo": "devenv-runtimes",
-            "version": "v2.2.6"
+            "version": "v3.1.1"
         },
         {
             "repo": "devenv-github-workflows",
-            "version": "v4.1.4"
+            "version": "v6.0.1"
         },
         {
             "repo": "devenv-github-templates",
-            "version": "v1.0.3"
+            "version": "v1.0.5"
         },
         {
             "repo": "devenv-devcontainer-setup",
-            "version": "v1.4.7"
+            "version": "v2.2.0"
         }
     ],
     "variables": {
diff --git a/testbench/test-init/.velocitasNew.json b/testbench/test-init/.velocitasNew.json
@@ -1,10 +1,10 @@
 {
     "packages": {
         "https://github.com/eclipse-velocitas/pkg-velocitas-main.git": "v0.0.2",
-        "https://github.com/eclipse-velocitas/devenv-devcontainer-setup.git": "v2.0.0",
-        "https://github.com/eclipse-velocitas/devenv-runtimes.git": "v3.0.0",
-        "https://github.com/eclipse-velocitas/devenv-github-templates.git": "v1.0.3",
-        "https://github.com/eclipse-velocitas/devenv-github-workflows.git": "v5.0.0"
+        "https://github.com/eclipse-velocitas/devenv-devcontainer-setup.git": "v2.2.0",
+        "https://github.com/eclipse-velocitas/devenv-runtimes.git": "v3.1.1",
+        "https://github.com/eclipse-velocitas/devenv-github-templates.git": "v1.0.5",
+        "https://github.com/eclipse-velocitas/devenv-github-workflows.git": "v6.0.1"
     },
     "components": [
         "vapp-core-python",
@@ -22,5 +22,5 @@
         "appManifestPath": "./app/AppManifest.json",
         "githubRepoId": "<myrepo>"
     },
-    "cliVersion": "v0.6.3"
+    "cliVersion": "v0.9.0"
 }
diff --git a/testbench/test-init/app/AppManifest.json b/testbench/test-init/app/AppManifest.json
@@ -5,7 +5,7 @@
         {
             "type": "vehicle-signal-interface",
             "config": {
-                "src": "https://github.com/COVESA/vehicle_signal_specification/releases/download/v3.0/vss_rel_3.0.json",
+                "src": "https://github.com/COVESA/vehicle_signal_specification/releases/download/v4.0/vss_rel_4.0.json",
                 "datapoints": {
                     "required": [
                         {

Original file line number	Diff line number	Diff line change
`@@ -106,6 +106,17 @@`
`106`	`106`	`]`
`107`	`107`	`}`
`108`	`108`	`]`
	`109`	`+ },`
	`110`	`+ {`
	`111`	`+ "id": "devcontainer-setup-java",`
	`112`	`+ "type": "extension",`
	`113`	`+ "name": "devContainer Setup uProtocol Java",`
	`114`	`+ "description": "VSCode devContainer setup for uProtocol Java applications",`
	`115`	`+ "mandatory": true,`
	`116`	`+ "compatibleCores": [`
	`117`	`+ "uprotocol-core-java"`
	`118`	`+ ],`
	`119`	`+ "parameters": []`
`109`	`120`	`}`
`110`	`121`	`]`
`111`	`122`	`},`
`@@ -136,7 +147,7 @@`
`136`	`147`	`{`
`137`	`148`	`"id": "src",`
`138`	`149`	`"description": "URI or path to VSS json",`
`139`		`- "default": "https://github.com/COVESA/vehicle_signal_specification/releases/download/v3.0/vss_rel_3.0.json",`
	`150`	`+ "default": "https://github.com/COVESA/vehicle_signal_specification/releases/download/v4.0/vss_rel_4.0.json",`
`140`	`151`	`"required": true,`
`141`	`152`	`"type": "string"`
`142`	`153`	`},`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`{`
`6`	`6`	`"type": "vehicle-signal-interface",`
`7`	`7`	`"config": {`
`8`		`- "src": "https://github.com/COVESA/vehicle_signal_specification/releases/download/v3.0/vss_rel_3.0.json",`
	`8`	`+ "src": "https://github.com/COVESA/vehicle_signal_specification/releases/download/v4.0/vss_rel_4.0.json",`
`9`	`9`	`"datapoints": {`
`10`	`10`	`"required": [`
`11`	`11`	`{`
Original file line number	Diff line number	Diff line change
`@@ -2,19 +2,19 @@`
`2`	`2`	`"packages": [`
`3`	`3`	`{`
`4`	`4`	`"repo": "devenv-runtimes",`
`5`		`- "version": "v2.2.6"`
	`5`	`+ "version": "v3.1.1"`
`6`	`6`	`},`
`7`	`7`	`{`
`8`	`8`	`"repo": "devenv-github-workflows",`
`9`		`- "version": "v4.1.4"`
	`9`	`+ "version": "v6.0.1"`
`10`	`10`	`},`
`11`	`11`	`{`
`12`	`12`	`"repo": "devenv-github-templates",`
`13`		`- "version": "v1.0.3"`
	`13`	`+ "version": "v1.0.5"`
`14`	`14`	`},`
`15`	`15`	`{`
`16`	`16`	`"repo": "devenv-devcontainer-setup",`
`17`		`- "version": "v1.4.7"`
	`17`	`+ "version": "v2.2.0"`
`18`	`18`	`}`
`19`	`19`	`],`
`20`	`20`	`"variables": {`