Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retry option to deployed services #887

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add retry option to deployed services #887

wants to merge 1 commit into from

Conversation

WangLiNaruto
Copy link
Contributor

@WangLiNaruto WangLiNaruto commented Jun 13, 2024 •
edited
Loading

@WangLiNaruto WangLiNaruto reopened this Jun 13, 2024
@WangLiNaruto WangLiNaruto force-pushed the feature/retry_deploy_service branch 4 times, most recently from 21b7258 to a6198d3 Compare June 13, 2024 09:39
@baixinsui
Copy link
Contributor

LGTM

@Alice1319
Copy link
Contributor

LGTM

@WangLiNaruto WangLiNaruto force-pushed the feature/retry_deploy_service branch 3 times, most recently from 995db1b to f55b2dc Compare June 17, 2024 09:40
@WangLiNaruto WangLiNaruto reopened this Jun 17, 2024
@WangLiNaruto WangLiNaruto force-pushed the feature/retry_deploy_service branch 2 times, most recently from eba9d7f to ecd6c5b Compare June 20, 2024 12:29
@WangLiNaruto WangLiNaruto force-pushed the feature/retry_deploy_service branch 3 times, most recently from b585958 to 15e537c Compare June 24, 2024 03:22
swaroopar
swaroopar requested changes Jun 24, 2024
View reviewed changes
src/components/content/order/create/OrderSubmit.tsx Show resolved Hide resolved
src/components/content/order/orderStatus/OrderSubmitStatusAlert.tsx Outdated
@@ -105,6 +139,11 @@ function OrderSubmitStatusAlert({
}
}

const reDeployService = () => {
stopWatch.reset();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the timer is still set to 0 and does not start after clicking the "retry request" button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swaroopar swaroopar swaroopar requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add retry option to deployed services
4 participants
@WangLiNaruto @baixinsui @Alice1319 @swaroopar