Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change terraform-boot and tofu-maker unittest to use wiremock for github API #2316

Open
3 tasks
swaroopar opened this issue Jan 20, 2025 · 1 comment
Open
3 tasks

change terraform-boot and tofu-maker unittest to use wiremock for github API #2316

swaroopar opened this issue Jan 20, 2025 · 1 comment
Assignees
@Alice1319
Labels
Accepted Issues that have been accepted and planned terraform-boot test user stories to create tests tofu-maker Issues related to tofu-maker app
Milestone
Sprint 032025_1

Comments

@swaroopar
Copy link
Contributor

Currently the terraform-boot and tofu-maker unittests use the actual Github API and this is causing the tests to be fail intermittently due to rate limiting feature of GitHub api.

  • Disable the current test by default.
  • Add similar test but with GitHub API mocked with wiremock.
  • Change in both terraform-boot and tofu-maker.
@swaroopar swaroopar added Accepted Issues that have been accepted and planned terraform-boot test user stories to create tests tofu-maker Issues related to tofu-maker app labels Jan 20, 2025
@swaroopar swaroopar added this to the Sprint 012025_1 milestone Jan 20, 2025
@Alice1319
Copy link
Contributor

I‘ll take this.

@swaroopar swaroopar modified the milestones: Sprint 012025_2, 022025_1 Feb 3, 2025
@swaroopar swaroopar moved this to Planned in eclipse-xpanse Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alice1319 Alice1319

Labels
Accepted Issues that have been accepted and planned terraform-boot test user stories to create tests tofu-maker Issues related to tofu-maker app
Projects
eclipse-xpanse
Status: Planned
Milestone
Sprint 032025_1
Development

No branches or pull requests
2 participants
@Alice1319 @swaroopar