Make healthCheck only for Admin #2425
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AKARSHITJOSHI
force-pushed
the
feature/2379-healthcheck-admin-only
branch
4 times, most recently
from
c7ff7f3 to
449cc17
Compare
swaroopar
requested changes
Feb 19, 2025
modules/models/src/main/java/org/eclipse/xpanse/modules/models/system/SystemStatus.java
Outdated
Show resolved
Hide resolved
modules/models/src/main/java/org/eclipse/xpanse/modules/models/system/StackStatus.java
Outdated
Show resolved
Hide resolved
modules/models/src/main/java/org/eclipse/xpanse/modules/models/system/StackStatus.java
Outdated
Show resolved
Hide resolved
AKARSHITJOSHI
force-pushed
the
feature/2379-healthcheck-admin-only
branch
from
449cc17 to
40a74bf
Compare
swaroopar
approved these changes
Feb 20, 2025
|
LGTM |
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
AKARSHITJOSHI
force-pushed
the
feature/2379-healthcheck-admin-only
branch
from
40a74bf to
4d2114b
Compare
AKARSHITJOSHI
force-pushed
the
feature/2379-healthcheck-admin-only
branch
from
4d2114b to
af83c61
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2379
Remove method
private void processShownFields(BackendSystemStatus backendSystemStatus)Allow healthCheck() method only for 'ADMIN' ROLE and rename method to stackHealthStatus() -> /xpanse/stack/health
Rename existing SystemStatus data model to -> StackStatus
create new method -> healthCheck() -> which returns only new SystemStatus data model which has only 'HealthStatus' as a property.
5.Allow new method to all roles - admin, user, isv and csp.
Note : endpoint ->
"/health"changed to"/stack/health"allowed only for adminnew endpoint ->
"/health"allowed for all users.