Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make healthcheck only for admin users and create new service for all users #2379

Open
6 tasks
swaroopar opened this issue Feb 8, 2025 · 4 comments · May be fixed by #2425
Open
6 tasks

make healthcheck only for admin users and create new service for all users #2379

swaroopar opened this issue Feb 8, 2025 · 4 comments · May be fixed by #2425
Assignees
@AKARSHITJOSHI
Labels
Accepted Issues that have been accepted and planned api enhancement New feature or request good first issue Good for newcomers UI Issues related to Xpanse UI
Milestone
Sprint 032025_1

Comments

@swaroopar
Copy link
Contributor

Currently the healthcheck service is allowed for all users. This must be changed. Since only admin must know all configuration and backend systems involved the entire stack.

  • remove processShownFields method -

    xpanse/modules/api/src/main/java/org/eclipse/xpanse/api/controllers/AdminServicesApi.java

    Line 193 in 1f8d0a2

    private void processShownFields(BackendSystemStatus backendSystemStatus) {
  • Allow healthCheck() method only for 'ADMIN' ROLE and rename method to stackHealthStatus() -> /xpanse/stack/health
  • Rename existing SystemStatus data model to -> StackStatus
  • create new method -> healthCheck() -> which returns only new SystemStatus data model which has only 'HealthStatus' as a property.
  • Allow new method to all roles - admin, user, isv and csp.
  • Update UI to use the new healthCheck in layout header. and stackHealthStatus() in admin's healthcheck component.
@swaroopar swaroopar added Accepted Issues that have been accepted and planned api enhancement New feature or request UI Issues related to Xpanse UI labels Feb 8, 2025
@swaroopar swaroopar added this to the Sprint 022025_1 milestone Feb 8, 2025
@swaroopar swaroopar self-assigned this Feb 8, 2025
@swaroopar swaroopar added the good first issue Good for newcomers label Feb 8, 2025
@swaroopar swaroopar removed their assignment Feb 8, 2025
@AKARSHITJOSHI
Copy link
Contributor

@swaroopar I would love to give this a try.

@swaroopar
Copy link
Contributor Author

@AKARSHITJOSHI yes please feel free to do it. Are you also part of Eclipse Foundation? If not, you must sign the committer agreement first.
https://eclipse.dev/xpanse/docs/Contribute/new-developers#signing-the-eca

@swaroopar
Copy link
Contributor Author

@AKARSHITJOSHI are you working on this?

@AKARSHITJOSHI
Copy link
Contributor

@AKARSHITJOSHI are you working on this?

Yes I will raise PR be EOD.

@swaroopar swaroopar moved this to Planned in eclipse-xpanse Feb 18, 2025
@AKARSHITJOSHI AKARSHITJOSHI linked a pull request Feb 18, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AKARSHITJOSHI AKARSHITJOSHI

Labels
Accepted Issues that have been accepted and planned api enhancement New feature or request good first issue Good for newcomers UI Issues related to Xpanse UI
Projects
eclipse-xpanse
Status: Planned
Milestone
Sprint 032025_1
Development

Successfully merging a pull request may close this issue.

Make healthCheck only for Admin AKARSHITJOSHI/xpanse
2 participants
@AKARSHITJOSHI @swaroopar