Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support waiting on condition variable until a specific time point #665

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

bjsowa
Copy link
Contributor

@bjsowa bjsowa commented Sep 16, 2024

This is my proposal for supporting waiting on condition variable till a specific time point. For now, I only implemented it for unix. If this gets approved, I can implement this function for the rest of the ports.

Copy link

PR missing one of the required labels: {'new feature', 'enhancement', 'dependencies', 'internal', 'documentation', 'breaking-change', 'bug'}

@jean-roland
Copy link
Contributor

Hello @bjsowa, thanks for your contribution. Just to make sure since your PR is in draft, do you want us to give it a look as is?

@bjsowa
Copy link
Contributor Author

bjsowa commented Sep 24, 2024

Hello @bjsowa, thanks for your contribution. Just to make sure since your PR is in draft, do you want us to give it a look as is?

Yes, I would like to discuss the interface first. Once it's approved, I will implement it for different ports

@jean-roland
Copy link
Contributor

OK then we'll check this a bit later, when we have time™.

@jean-roland
Copy link
Contributor

Hey @bjsowa, the approach looks fine to us.

Just a note, since we're in the process of releasing Zenoh 1.0, we'll only be able to merge the changes after the release.

Copy link

PR missing one of the required labels: {'dependencies', 'enhancement', 'breaking-change', 'new feature', 'bug', 'internal', 'documentation'}

Copy link

PR missing one of the required labels: {'dependencies', 'enhancement', 'documentation', 'new feature', 'breaking-change', 'internal', 'bug'}

Copy link

PR missing one of the required labels: {'bug', 'new feature', 'breaking-change', 'dependencies', 'internal', 'documentation', 'enhancement'}

Copy link

PR missing one of the required labels: {'internal', 'enhancement', 'bug', 'new feature', 'breaking-change', 'dependencies', 'documentation'}

Copy link

PR missing one of the required labels: {'documentation', 'enhancement', 'bug', 'dependencies', 'breaking-change', 'new feature', 'internal'}

Copy link

PR missing one of the required labels: {'bug', 'dependencies', 'breaking-change', 'internal', 'enhancement', 'new feature', 'documentation'}

@sashacmc sashacmc added the enhancement Things could work better label Dec 6, 2024
@bjsowa
Copy link
Contributor Author

bjsowa commented Dec 7, 2024

I'll try to finish this PR after #821 gets merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Things could work better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants