Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sitemap date not updated when an extension version is deleted #955

Open
hoangphamEclipse opened this issue Jun 26, 2024 · 0 comments · May be fixed by #956
Open

Sitemap date not updated when an extension version is deleted #955

hoangphamEclipse opened this issue Jun 26, 2024 · 0 comments · May be fixed by #956

Comments

@hoangphamEclipse
Copy link
Contributor

When an extension version is deleted, the last_updated_date of its extension database entry is not updated. This causes the mirror to be out-of-sync with upstream.

For example:

  • Extension Ext has 2 versions ExtV0.0.1 and ExtV0.0.2. Then the last_udpated_date will be the published date of ExtV0.0.2.
  • For some reason ExtV0.0.1 is deleted, but the last updated time is not changed.
  • Thus, the mirror wont update the metadata on its end.

This issue causes the mirror to throw an error when its trying to remove some out-of-date extensions.
hoangphamEclipse added a commit to hoangphamEclipse/openvsx that referenced this issue Jun 26, 2024
@hoangphamEclipse
Update last-updated-date of extensions whenever extension is changed
7f10ccc 
Currently, the last-updated-date is only updated when a new extension version
is published. This causes the mirror to be out-of-sync with upstream whenever
an extension version is deleted.

This commit updates the last-updated-date whenever an extension is changed,
including the scenario above.

Fixes eclipse#955.

Signed-off-by: Hoang Thuan Pham <[email protected]>
@hoangphamEclipse hoangphamEclipse linked a pull request Jun 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update last-updated-date of extensions whenever extension is changed hoangphamEclipse/openvsx
1 participant
@hoangphamEclipse