the current implementain logic is just simply not work!

[dangbinghoo]

hi there, has been integrated the current code to a iot project running with FreeRTOS + lwip, and found out the FreeRTOS verison of MQTTClient.c implementation is just wholly messed.

the cycle function just simply sign "not connected" and "clean all the subscribed topics" even when a simple error occured.

makes that the client just can connect to the broker and then simply ignores all received msg as you may receive a subscribe ack later in 1 second after sending the request, and sign "not connected" when running the MQTTYield will just cause you won't publish out any msg and return -1.

the all code logic is just weird.

[scaprile]

Oh, if you happen to know more than the developers then please do it right and send a pull request!

[CIPop]

the cycle function just simply sign "not connected" and "clean all the subscribed topics" even when a simple error occured. makes that the client just can connect to the broker and then simply ignores all received msg

This is the correct behavior according to the spec. See section 3.1.2.4.

We do need to check to see if this is happening if clean_session / clean_start are set to false, which would be a bug.