[2810] Allow private config to override output directories and filename - #2811
Open
evenmn wants to merge 7 commits into
Open
[2810] Allow private config to override output directories and filename#2811evenmn wants to merge 7 commits into
evenmn wants to merge 7 commits into
Conversation
Collaborator
|
@grassesi : could you also have a look? |
Collaborator
|
@evenmn : could you lint please :) |
clessig
reviewed
Sep 11, 2026
clessig
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, this is a useful feature. Some minor comments. We also should merge this into the preops branch.
Signed-off-by: evenmn <evenmn@fys.uio.no>
Signed-off-by: evenmn <evenmn@fys.uio.no>
Contributor
Author
|
@clessig Thank you for the comments. Please have a look at my answers and latest commits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds optional
private_configoverrides for model, log, and results directories, plus the output filename. Explicit directories are used directly, without appending the run ID. Existing defaults remain when overrides are omitted.Checkpoint loading and logging use the selected private configuration.
Issue Number
Closes #2810
Is this PR a draft? Mark it as draft.
Checklist before asking for review
./scripts/actions.sh lint./scripts/actions.sh unit-test./scripts/actions.sh integration-testlaunch-slurm.py --time 60FastEvaluation