feat: complete env_resolution migration for remaining env var literals

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: eastgate

bin/loamspine-service/main.rs

@@ -204,14 +204,13 @@ async fn run_server(
 
     let rpc_service = {
         let svc = LoamSpineRpcService::new(service);
-        let tower_socket = std::env::var("TOWER_SIGNER_SOCKET")
-            .or_else(|_| std::env::var("BEARDOG_SOCKET"));
-        if let Ok(socket_val) = tower_socket {
+        let tower_socket = loam_spine_core::constants::env_resolution::tower_signer_socket();
+        if let Some(socket_val) = tower_socket {
             let socket_path = std::path::PathBuf::from(&socket_val);
             info!("Tower signing enabled via TOWER_SIGNER_SOCKET={socket_val}");
-            let signer_did = std::env::var("TOWER_SIGNER_DID")
+            let signer_did = loam_spine_core::constants::env_resolution::tower_signer_did()
                 .map(loam_spine_core::types::Did::new)
-                .unwrap_or_else(|_| loam_spine_core::types::Did::anonymous());
+                .unwrap_or_else(loam_spine_core::types::Did::anonymous);
             let signer = std::sync::Arc::new(
                 loam_spine_core::traits::crypto_provider::JsonRpcCryptoSigner::new(
                     socket_path,
@@ -315,7 +314,7 @@ async fn run_server(
     };
 
     #[cfg(unix)]
-    let family_id = std::env::var("BIOMEOS_FAMILY_ID").ok();
+    let family_id = loam_spine_core::constants::env_resolution::biomeos_family_id();
 
     // Capability-domain symlink: ledger.sock → loamspine.sock
     // Enables orchestration-layer `by_capability = "ledger"` routing in deploy graphs.

crates/loam-spine-api/src/jsonrpc/method_gate.rs

@@ -56,8 +56,7 @@ impl AuthMode {
     /// Unset or unrecognized defaults to `Permissive`.
     #[must_use]
     pub fn from_env() -> Self {
-        std::env::var("LOAMSPINE_AUTH_MODE")
-            .ok()
+        loam_spine_core::constants::env_resolution::loamspine_auth_mode()
             .and_then(|v| match v.to_ascii_lowercase().as_str() {
                 "enforced" => Some(Self::Enforced),
                 "permissive" => Some(Self::Permissive),

crates/loam-spine-api/src/jsonrpc/uds.rs

@@ -462,7 +462,7 @@ fn is_btsp_ndjson(line: &str) -> bool {
 
 /// Resolve the BTSP provider socket from environment for NDJSON auto-detect.
 fn resolve_btsp_provider() -> Option<std::path::PathBuf> {
-    if let Ok(path) = std::env::var("BTSP_PROVIDER_SOCKET") {
+    if let Some(path) = loam_spine_core::constants::env_resolution::btsp_provider_socket() {
         return Some(std::path::PathBuf::from(path));
     }
     let config = loam_spine_core::btsp::BtspHandshakeConfig::from_env()?;

crates/loam-spine-core/src/btsp/config.rs

@@ -24,7 +24,8 @@ const DEFAULT_BTSP_PROVIDER_PREFIX: &str = "btsp-provider";
 /// Checks `BTSP_PROVIDER` env var first, allowing runtime configuration
 /// of the handshake provider without compile-time primal coupling.
 fn btsp_provider_prefix() -> String {
-    std::env::var("BTSP_PROVIDER").unwrap_or_else(|_| DEFAULT_BTSP_PROVIDER_PREFIX.into())
+    crate::constants::env_resolution::btsp_provider()
+        .unwrap_or_else(|| DEFAULT_BTSP_PROVIDER_PREFIX.into())
 }
 
 /// Pure variant for testing and explicit configuration.
@@ -81,11 +82,11 @@ impl BtspHandshakeConfig {
     /// meaning BTSP is required. Returns `None` in development mode.
     #[must_use]
     pub fn from_env() -> Option<Self> {
-        let provider_socket_override = std::env::var("BTSP_PROVIDER_SOCKET").ok();
+        let provider_socket_override = crate::constants::env_resolution::btsp_provider_socket();
         Self::from_values(
-            std::env::var("BIOMEOS_FAMILY_ID").ok().as_deref(),
+            crate::constants::env_resolution::biomeos_family_id().as_deref(),
             provider_socket_override.as_deref(),
-            std::env::var("BIOMEOS_SOCKET_DIR").ok().as_deref(),
+            crate::constants::env_resolution::biomeos_socket_dir().as_deref(),
         )
     }
 }
@@ -148,7 +149,9 @@ pub(crate) fn provider_socket_name(
 /// Returns `true` when `BIOMEOS_FAMILY_ID` is set and not `"default"`.
 #[must_use]
 pub fn is_btsp_required() -> bool {
-    is_btsp_required_with(std::env::var("BIOMEOS_FAMILY_ID").ok().as_deref())
+    is_btsp_required_with(
+        crate::constants::env_resolution::biomeos_family_id().as_deref(),
+    )
 }
 
 /// Pure inner function: check BTSP requirement from explicit values.

crates/loam-spine-core/src/btsp/handshake.rs

@@ -509,10 +509,7 @@ fn decode_session_key(session_key: Option<&String>) -> Option<[u8; 32]> {
 pub(crate) fn resolve_family_seed() -> Result<String, LoamSpineError> {
     use base64::Engine;
 
-    let raw = std::env::var("FAMILY_SEED")
-        .or_else(|_| std::env::var("BTSP_FAMILY_SEED"))
-        .or_else(|_| std::env::var("BEARDOG_FAMILY_SEED"))
-        .map_err(|_| {
+    let raw = crate::constants::env_resolution::family_seed().map_err(|_| {
             LoamSpineError::ipc(
                 IpcErrorPhase::Connect,
                 "FAMILY_SEED not set (checked FAMILY_SEED, BTSP_FAMILY_SEED, and BEARDOG_FAMILY_SEED)",

crates/loam-spine-core/src/config.rs

@@ -179,18 +179,16 @@ impl Default for DiscoveryConfig {
         let tarpc = crate::constants::env_resolution::tarpc_port();
         let jsonrpc = crate::constants::env_resolution::jsonrpc_port();
 
-        let discovery_enabled = std::env::var("LOAMSPINE_DISCOVERY_ENABLED")
-            .map(|v| !matches!(v.as_str(), "0" | "false" | "no"))
-            .unwrap_or(true);
+        let discovery_enabled = crate::constants::env_resolution::discovery_enabled();
 
         Self {
             discovery_enabled,
-            discovery_endpoint: std::env::var("DISCOVERY_ENDPOINT").ok(),
+            discovery_endpoint: crate::constants::env_resolution::discovery_endpoint(),
 
-            tarpc_endpoint: std::env::var("TARPC_ENDPOINT")
-                .unwrap_or_else(|_| format!("http://{bind}:{tarpc}")),
-            jsonrpc_endpoint: std::env::var("JSONRPC_ENDPOINT")
-                .unwrap_or_else(|_| format!("http://{bind}:{jsonrpc}")),
+            tarpc_endpoint: crate::constants::env_resolution::tarpc_endpoint()
+                .unwrap_or_else(|| format!("http://{bind}:{tarpc}")),
+            jsonrpc_endpoint: crate::constants::env_resolution::jsonrpc_endpoint()
+                .unwrap_or_else(|| format!("http://{bind}:{jsonrpc}")),
 
             auto_advertise: true,
             heartbeat_interval_seconds: 60,