Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup raster/sf use WIP #48

Open
mdsumner opened this issue Dec 7, 2022 · 1 comment
Open

cleanup raster/sf use WIP #48

mdsumner opened this issue Dec 7, 2022 · 1 comment

Comments

@mdsumner
Copy link
Collaborator

mdsumner commented Dec 7, 2022

tentatively , I'll just sit on this a while but see branch remove-raster-method

  • remove raster() method
  • re-export both plot() and raster() from raster
  • remove sp and methods dep (because we aren't defining a raster('sf') method

need to determine sensible crs behaviour (we were copying the sf$crs$proj4string to r@crs when using raster(sf))

situations are

-[x] input sf has NA crs, do nothing
-[x] input sf has crs, input raster has NA crs ,do nothing
-[ ] input sf has crs, input raster has crs and they are different
-[x] input sf has crs, input raster has crs and they are same, do nothing

the only thing to do is st_transform when both are set but different, but do we check if there's wkt/projstring in the raster?

@mdsumner
Copy link
Collaborator Author

mdsumner commented Dec 8, 2022

see https://github.com/diminutive/hackspatialcpp for some Cpp that gets what we need from sf

the removal is now merged into master with #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant