Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import/unambiguous对于Typescript declaration(.d.ts)文件的检查是多余的？ #64

Open
franckchen opened this issue Sep 2, 2021 · 3 comments · May be fixed by #65
Open

import/unambiguous对于Typescript declaration(.d.ts)文件的检查是多余的？ #64

franckchen opened this issue Sep 2, 2021 · 3 comments · May be fixed by #65

Comments

@franckchen
Copy link
Contributor

项目里有.d.ts文件时， 经常会报违背了import/unambiguous规则

这个规则我理解和Typescript的isolatedModules是重叠的， 且isolatedModules规则自动忽略.d.ts， 而import/unambiguous不会, 所以误报是经常的(除非.d.ts里有import)

感觉应该增加overrides, 忽略这条规则对于.d.ts文件的检查。准备尝试PR~
franckchen added a commit to franckchen/eslint-config that referenced this issue Sep 2, 2021
@franckchen
fix: 修改import/unambiguous规则对于Typescript declaration文件(.d.ts)的错误、冗余检查
2ae2164 
fixes ecomfe#64
franckchen added a commit to franckchen/eslint-config that referenced this issue Sep 2, 2021
@franckchen
fix: 修改import/unambiguous规则对于Typescript declaration文件(.d.ts)的错误、冗余检查
f3e3738 
fixes ecomfe#64
@franckchen franckchen linked a pull request Sep 2, 2021 that will close this issue
Open
@otakustay
Copy link
Member

干脆点，直接ignorePatterns把d.ts排除在所有规则外如何

@franckchen
Copy link
Contributor Author

.d.ts排除所有import相关规则吗？感觉可以啊。如果是排除于所有规则之外，感觉略激进吧， 所有的语法规则都不检查了吗？如果是前者的话怎么加呢？ 在这个文件里加了ignorePatters应该是.d.ts就不经过所有的规则的检查了，感觉略难受。 有些没太理解怎么改好些~😢

@otakustay
Copy link
Member

我这的做法是排除所有规则的，比如d.ts里会有const定义但不赋值的，那就连init-declare都不能检查了，非常多的规则都是废的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@otakustay @franckchen