Add instance static class #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaucy
reviewed
Oct 4, 2022
zaucy
reviewed
Oct 4, 2022
zaucy
reviewed
Oct 4, 2022
zaucy
reviewed
Oct 4, 2022
zaucy
reviewed
Oct 4, 2022
Comment on lines
103
to
109
| EcsactRunner.OnRuntimeLoad<DefaultFixedRunner>( | ||
| EcsactRuntimeDefaultRegistry.RunnerType.FixedUpdate, | ||
| "Default Fixed Runner" | ||
| ); |
There was a problem hiding this comment.
I think instead of having OnRuntimeLoad set the Default we could have it return the runner in question?
Then this could look like:
Suggested change
| EcsactRunner.OnRuntimeLoad<DefaultFixedRunner>( | |
| EcsactRuntimeDefaultRegistry.RunnerType.FixedUpdate, | |
| "Default Fixed Runner" | |
| ); | |
| Ecsact.Defaults.Runner = DefaultFixedRunner.OnRuntimeLoad( | |
| EcsactRuntimeDefaultRegistry.RunnerType.FixedUpdate, | |
| "Default Fixed Runner" | |
| ); |
I'd probably rename OnRuntimeLoad to something more appropriate, however.
zaucy
reviewed
Oct 4, 2022
|
@Kelwan I updated your PR to point to |
zaucy
reviewed
Oct 13, 2022
zaucy
reviewed
Oct 13, 2022
Kelwan
force-pushed
the
feat/add-static-instance-class
branch
2 times, most recently
from
f983f50 to
9242d84
Compare
…to latest and add it all in
Kelwan
force-pushed
the
feat/add-static-instance-class
branch
from
ea0172e to
4bfd4bf
Compare
zaucy
reviewed
Oct 18, 2022
Runtime/EcsactDefaults.cs
Outdated
Comment on lines
12
to
16
| public static EcsactRuntime Runtime => _Runtime | ||
| ?? throw new Exception( | ||
| "Runtime is null, if you want to access it as early as possible" + | ||
| " use Ecsact.Defaults.WhenReady" | ||
| ); |
There was a problem hiding this comment.
Suggested change
| public static EcsactRuntime Runtime => _Runtime | |
| ?? throw new Exception( | |
| "Runtime is null, if you want to access it as early as possible" + | |
| " use Ecsact.Defaults.WhenReady" | |
| ); | |
| public static EcsactRuntime Runtime => _Runtime ?? throw new Exception( | |
| "Runtime is null, if you want to access it as early as possible" + | |
| " use Ecsact.Defaults.WhenReady" | |
| ); |
zaucy
reviewed
Oct 18, 2022
Comment on lines
23
to
25
| Ecsact.Defaults.WhenReady(() => { | ||
| Load(); | ||
| }); |
There was a problem hiding this comment.
Suggested change
| Ecsact.Defaults.WhenReady(() => { | |
| Load(); | |
| }); | |
| Ecsact.Defaults.WhenReady(Load); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38