13 Expanding System domain to all REST layers #25
Conversation
Convert related domain records to domain classes. Add domain repositories Add a copy of Infrastructure utilities from Kafka Add SystemMapper
…-repository-+-infrastructure-for-system
…ontains for all. Add bean to enable Lazy loading by default to prevent excessive data loading Pull development updates Generate Persistence Repositories Flagged liquibase systems table for update
…-repository-+-infrastructure-for-system
remove 0014-add-star_class-to-systems-table.xml change ALL tables to singular
remove 0014-add-star_class-to-systems-table.xml change ALL tables to singular
Update changelog to allow coords to be null change x/y/z -> x_coordinate/y_coordinate/z_coordinate Update processors to work with inbound schema changes Remove star clas from nav route
…astructure-for-system' into 13-rest-domain-repository-+-infrastructure-for-system
create application layer for System add System beans add dev profile back to application.properties temporarily remove logback from rest
… format add logs file to gitignore
13 - intermediate review
replace get-named files for application with find-naming fold in System bean configuration to BeanConfig update logback default folder to prevent conflicts
…-repository-+-infrastructure-for-system # Conflicts: # liquibase/src/main/resources/changelog/changelog-master.xml # message-processors/commodityv3-processor/src/main/java/io/edpn/backend/messageprocessor/commodityv3/infrastructure/persistence/mappers/CommodityEntityMapper.java # message-processors/commodityv3-processor/src/main/java/io/edpn/backend/messageprocessor/commodityv3/infrastructure/persistence/mappers/EconomyEntityMapper.java # message-processors/commodityv3-processor/src/main/java/io/edpn/backend/messageprocessor/commodityv3/infrastructure/persistence/mappers/HistoricStationCommodityMarketDatumEntityMapper.java # message-processors/commodityv3-processor/src/main/java/io/edpn/backend/messageprocessor/commodityv3/infrastructure/persistence/mappers/StationEntityMapper.java # message-processors/commodityv3-processor/src/main/java/io/edpn/backend/messageprocessor/commodityv3/infrastructure/persistence/mappers/StationStationTypeEntityMapper.java # message-processors/commodityv3-processor/src/main/java/io/edpn/backend/messageprocessor/commodityv3/infrastructure/persistence/mappers/StationTypeEntityMapper.java # message-processors/commodityv3-processor/src/main/java/io/edpn/backend/messageprocessor/commodityv3/infrastructure/persistence/mappers/SystemEntityMapper.java
liquibase/src/main/resources/changelog/0001-create-system-table.xml
Outdated
Show resolved
Hide resolved
liquibase/src/main/resources/changelog/0022-expand-system-table.xml
Outdated
Show resolved
Hide resolved
liquibase/src/main/resources/changelog/0022-expand-system-table.xml
Outdated
Show resolved
Hide resolved
liquibase/src/main/resources/changelog/0022-expand-system-table.xml
Outdated
Show resolved
Hide resolved
...tyv3/infrastructure/persistence/mappers/HistoricStationCommodityMarketDatumEntityMapper.java
Outdated
Show resolved
Hide resolved
...processor/commodityv3/infrastructure/persistence/mappers/StationStationTypeEntityMapper.java
Outdated
Show resolved
Hide resolved
...end/messageprocessor/commodityv3/infrastructure/persistence/mappers/StationEntityMapper.java
Show resolved
Hide resolved
...kend/messageprocessor/commodityv3/infrastructure/persistence/mappers/SystemEntityMapper.java
Outdated
Show resolved
Hide resolved
...ageprocessor/fsssignaldiscoveredv1/infrastructure/persistence/mapper/SystemEntityMapper.java
Show resolved
Hide resolved
| @@ -1,6 +1,7 @@ | |||
| management.server.port=8080 | |||
| server.port=8080 | |||
|
|
|||
| spring.profiles.active=dev | |||
There was a problem hiding this comment.
this does not belong in the main appilcation.properties. this can have unintended side effects.
either set via maven run time or environment variable. not via application.properties
There was a problem hiding this comment.
Ive historically collapsed application.properties into one file that houses all of your runnable profiles.
But I can keep it going in separate files if we want to do something like application-dev.yaml
There was a problem hiding this comment.
https://reflectoring.io/spring-boot-profiles/
--> it is much easier to find properties for a certain profile an to compare them between profiles if they are split in different files. Also, the reference manual says that the multi-document syntax can lead to unexpected behavior.
They way you were doing it here, was kind of contradictory
You are setting the active profile in the same multi-document file, which defeats the purpose, as dev will always be active.
you were correctly using the `spring.config.activate.on-profile=dev, but I removed that in a previous change.
the better way is to put all the shared (and static) properties in the application.properties, and then a file per environment.
running it with the correct profile:
java -jar file.jar --spring-boot.run.profiles=production or mvn spring-boot:run -Dspring-boot.run.profiles=dev,pieter to set the correct profile.
this has the additional benefit of setting the correct profile for the logbck.xml
this means you can supply multiple profiles, where the later passed ones will overwrite properties of the previous.
you could make a application-daniel.properties, and run with profiles prod,daniel and you would run with prod properties, only overriding the once defined in application-daniel.properties
…ns to Mybatis and consolidating the initial database schema liquibase files
…n-repository-+-infrastructure-for-system # Conflicts: # message-processors/commodityv3-processor/src/main/java/io/edpn/backend/messageprocessor/commodityv3/infrastructure/persistence/mappers/EconomyEntityMapper.java # message-processors/commodityv3-processor/src/main/java/io/edpn/backend/messageprocessor/commodityv3/infrastructure/persistence/mappers/StationStationTypeEntityMapper.java
…n-repository-+-infrastructure-for-system
13 - fixing readded mapper endpoints, renaming all repo implementatio…
…astructure-for-system' into 13-rest-domain-repository-+-infrastructure-for-system
Update logback to prevent file conflict Add stationTypeID to commodityv3 Remove StationStationTypeEntityMapper.java
pveeckhout
deleted the
13-rest-domain-repository-+-infrastructure-for-system
branch
Created a full set of layers from Controller to persistence for System.
System will grow in the future as remaining entities get added.
Controller Methods will also grow to implement more searchable features in the future