Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing getters #9

Open
fredRos opened this issue Mar 27, 2015 · 4 comments
Open

Missing getters #9

fredRos opened this issue Mar 27, 2015 · 4 comments

Comments

@fredRos
Copy link

fredRos commented Mar 27, 2015

Thanks for creating this awesome package! I wanted to use it right away but quickly ran into problems. Seems like this project is still on the rise so I wanted to add suggestions for improvement:

  1. If there is setHead how come there is no getHead? To many users, this is a very important method. Please consider implementing it, but only after thorough testing.
  2. Maybe I was missing the point of the package but why is there no penis.getLength? The documentation states that this is about comparing variables and how can you do a penis.js comparison without the length? Seriously, you should go back and rub your head, then upload a new version.
@edankwan
Copy link
Owner

Good idea man! But for the penis.getLength(), what should be the return value? Also, do you think getSize() would be a better name?

@pappacena
Copy link

I've heard that getSize() doesn't matter.

@renatoferreirarenatoferreira

Yes, it does! It is only told by people who have uglyfied packages.

@rheber
Copy link

rheber commented Sep 13, 2018

For values which can be compared numerically, getSize() could be their absolute difference. Visualise the balls and head at points on a number line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants