Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dollar sign on command output interrupts execution #44

Closed
Markcial opened this issue May 11, 2017 · 3 comments
Closed

Dollar sign on command output interrupts execution #44

Markcial opened this issue May 11, 2017 · 3 comments

Comments

@Markcial
Copy link
Contributor

From sdkman/sdkman-cli#294 (comment)

Replacing line 50 of __bass.py with the following content fixes this issue:

script_lines.append("printf %s;printf '\\n'" % json.dumps(line.replace('$', '\$')))

but i don't know if there is more implications
@edc
Copy link
Owner

edc commented May 18, 2017 •
edited
Loading

@Markcial can you try doing it on line 71 just to be more conservative? If it works, would you mind sending a pull request?

@Markcial
Copy link
Contributor Author

Sorry, been busy lately, let me do the PR so you can check it, thanks

Markcial added a commit to Markcial/bass that referenced this issue May 24, 2017
@Markcial
fix: Solves issue with dollar signs on program outputs edc#44
5c0ac14
edc added a commit that referenced this issue May 24, 2017
@edc
Merge pull request #45 from Markcial/issue_44
7a8e8eb 
fix: Solves issue with dollar signs on program outputs #44
@edc edc closed this as completed May 24, 2017
@edc
Copy link
Owner

edc commented May 24, 2017

Fixed in #45 by @Markcial

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Markcial @edc