Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to simplify configuration #1

Open
uniquelau opened this issue Oct 12, 2022 · 2 comments
Open

Proposal to simplify configuration #1

uniquelau opened this issue Oct 12, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@uniquelau
Copy link

The rules are based around:

https://github.com/conventional-changelog/commitlint/blob/master/%40commitlint/config-conventional/index.js

I propose that we use this configuration as a base, and then add in the additional EDD specific rules.

https://edd-london.fibery.io/Wiki/Git-577/anchor=Types--3e1b3688-4a70-45d9-b528-5af1b1c9fdaf

image

This would simplify our package and remove the duplication.

@uniquelau uniquelau added the enhancement New feature or request label Oct 12, 2022
@Guled-Ibrahim
Copy link
Collaborator

I have added missing scopes and fixed other misc issues.

@uniquelau
Copy link
Author

Adding those extra bits looks good, but the configuration would be even simpler if we use this as the base and then that avoids the duplication, as currently it's essentially copy and pasted out of there ⬇️

@commitlint/config-conventional

There's a couple of different ways to extend an existing configuration, however, this is the simplest way:

https://github.com/conventional-changelog/commitlint/blob/master/%40commitlint/config-patternplate/index.js

As an aside, for these changes in future please can you make a new feature branch, and then create a PR, it is easier for the team to review that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants