fix: Update enum values for forms and submissions (#63)

reservoir-data · Dec 7, 2022 · 41d3cd1 · 41d3cd1
1 parent 9d5b886
commit 41d3cd1
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 4 deletions.
diff --git a/.github/workflows/dynamic-publish.yaml b/.github/workflows/dynamic-publish.yaml
@@ -37,6 +37,14 @@ jobs:
       - name: Build
         run: poetry build
 
+      - name: Upload wheel to release
+        uses: svenstaro/upload-release-action@v2
+        with:
+          file: dist/*.whl
+          tag: ${{ github.ref }}
+          overwrite: true
+          file_glob: true
+
       - name: Publish
         uses: pypa/[email protected]
         with:

diff --git a/tap_jotform/streams.py b/tap_jotform/streams.py
@@ -13,7 +13,6 @@
 
 CREATED_AT = th.Property("created_at", th.DateTimeType)
 UPDATED_AT = th.Property("updated_at", th.DateTimeType)
-STATUS = th.Property("status", th.StringType)
 
 
 class FormsStream(JotformPaginatedStream):
@@ -36,7 +35,11 @@ class FormsStream(JotformPaginatedStream):
         th.Property("title", th.StringType),
         th.Property("height", th.IntegerType),
         th.Property("url", th.StringType),
-        STATUS,
+        th.Property(
+            "status",
+            th.StringType,
+            allowed_values=["ENABLED", "DISABLED", "DELETED"],
+        ),
         CREATED_AT,
         UPDATED_AT,
         th.Property("last_submission", th.DateTimeType),
@@ -50,7 +53,7 @@ class FormsStream(JotformPaginatedStream):
             th.IntegerType,
             description="Total number of submissions",
         ),
-        th.Property("type", th.StringType),
+        th.Property("type", th.StringType, allowed_values=["LEGACY", "CARD"]),
         th.Property("favorite", th.IntegerType),
         th.Property("archived", th.IntegerType),
     ).to_dict()
@@ -141,7 +144,11 @@ class SubmissionsStream(JotformPaginatedStream):
         th.Property("notes", th.StringType),
         CREATED_AT,
         UPDATED_AT,
-        STATUS,
+        th.Property(
+            "status",
+            th.StringType,
+            allowed_values=["ACTIVE", "OVERQUOTA"],
+        ),
         th.Property(
             "new",
             th.IntegerType,