Adding Restart and Stop #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ifecycle - Introduced StopContainer RPC in EdgeContainerService to stop running containers. - Added ContainerCommand with a Stop subcommand to facilitate stopping containers via CLI. - Enhanced ControlCommand to support stop operations and added restart policy options for container execution. - Updated DockerCLI to include stop functionality for Docker containers. - Modified RunContainerRequestHandler to handle stopping containers and manage their state effectively.
zamderax
changed the title
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
The thing is I'm not sure if I'm on the right track. @Joannis should I delete DockerCLI? Since we aren't using Docker?
|
|
@zamderax I'd like to keep DockerCLI around, at least for now. It's also not the difficult part of this. I don't know enough about NerdCTL to make a call there. |
|
@mihai-chiorean this can be reviewed as a whole now |
# Conflicts: # Package.resolved # Sources/EdgeAgent/Services/AgentConfigService.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maps
--restart=unless-stoppedand--restart=noand--restart=on-failure:${number}toDockerCLINote
debughas--restart-noSolves #52