Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request generation might end too soon #2

Open
phip123 opened this issue Jul 4, 2022 · 0 comments
Open

Request generation might end too soon #2

phip123 opened this issue Jul 4, 2022 · 0 comments

Comments

@phip123
Copy link
Contributor

phip123 commented Jul 4, 2022

Currently the requests are executed in a sequential way, while the last ClientGroup will wait till it finishes all requests.

def requests():
for idx, group in enumerate(client_groups):
if idx == len(client_groups) - 1:
# TODO the wait here might return sooner than other profiles => implement solution that waits for all
group[2].request(ia=('prerecorded', 'ran')).wait()
else:
group[2].request(ia=('prerecorded', 'ran'))

In case the last ClientGroup has a profile much shorter than the others, the experiment will end too soon.

Solution: Dispatch all requests concurrently and wait for all of them to finish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant