From 364c521d7881eeff5e3125f2bd01d1cb3c493f41 Mon Sep 17 00:00:00 2001 From: Tim Hawes Date: Thu, 11 Jan 2024 19:05:15 +0000 Subject: [PATCH] mailman2: only allow subscription to public lists when advertised --- mailman2/views.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/mailman2/views.py b/mailman2/views.py index ade41c3..7e5a368 100644 --- a/mailman2/views.py +++ b/mailman2/views.py @@ -60,16 +60,20 @@ def build_overview_context(user): "name": mailing_list.name, "description": mailing_list.description, "archive_private": mailing_list.archive_private, - "visible": mailing_list.user_can_see(user), + "visible": False, "subscribed": False, "recommended": False, - "can_subscribe": mailing_list.user_can_subscribe(user), + "can_subscribe": False, "can_unsubscribe": False, "subscriptions": [], } row = 0 for address in verified_addresses: group_policy = mailing_list.user_subscribe_policy(user) + if mailing_list.advertised: + list_data["visible"] = True + if mailing_list.user_can_subscribe(user): + list_data["can_subscribe"] = True if group_policy: if group_policy.policy >= GroupPolicy.ALLOW: list_data["visible"] = True