Show job name in bg_job list/read_output/kill outputs

Surface the value passed via shell_command's `background` arg (stored as
`:summary`) as a quoted prefix in the bg_job tool outputs, so users see
e.g. `Background job "dev-server" (job-1) killed.` instead of just the id.

🤖 Generated with [eca](https://eca.dev)

Co-Authored-By: eca-agent <git@eca.dev>

Author: ericdallo

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+- `bg_job` now shows the job name (from `shell_command`'s `background` arg) in `list`, `read_output` and `kill` outputs, e.g. `Background job "dev-server" (job-1) killed.`.
+
 ## 0.135.3
 
 - Fix plugin primary agents being dropped from the selector when model sync finishes after plugin resolution.

src/eca/features/tools/background.clj

@@ -6,19 +6,21 @@
 
 (set! *warn-on-reflection* true)
 
-;; ---------------------------------------------------------------------------
-;; Action handlers
-;; ---------------------------------------------------------------------------
+(defn ^:private job-prefix
+  "Render `\"<name>\" (job-id)` when the job has a `:summary`, otherwise just the id."
+  [{:keys [id summary]}]
+  (if-let [s (not-empty summary)]
+    (str "\"" s "\" (" id ")")
+    id))
 
 (defn ^:private action-list [_arguments]
   (let [jobs (remove :notified (bg/list-jobs))]
     (if (seq jobs)
       (tools.util/single-text-content
        (string/join
         "\n"
-        (map (fn [{:keys [id type label summary status exit-code] :as job}]
-               (str "- " id
-                    (when summary (str " (" summary ")"))
+        (map (fn [{:keys [type label status exit-code] :as job}]
+               (str "- " (job-prefix job)
                     " [" (name type) "] "
                     (name status)
                     (when exit-code (str " (exit " exit-code ")"))
@@ -30,31 +32,30 @@
 (defn ^:private action-read-output [{:keys [job-id]}]
   (if-let [result (bg/read-output! job-id)]
     (let [{:keys [lines dropped status exit-code]} result
+          prefix (if-let [job (bg/get-job job-id)]
+                   (job-prefix job)
+                   job-id)
           output (if (seq lines)
                    (string/join "\n" (map bg/format-output-line lines))
                    "(no new output)")]
       (tools.util/single-text-content
-       (str "Job " job-id " — " (name status)
+       (str "Job " prefix " — " (name status)
             (when exit-code (str " (exit " exit-code ")"))
             (when (pos? dropped) (str "\n[" dropped " lines dropped from buffer]"))
             "\n\n" output)))
     (tools.util/single-text-content (str "Background job " job-id " not found.") true)))
 
 (defn ^:private action-kill [{:keys [job-id]}]
-  (if (bg/get-job job-id)
+  (if-let [job (bg/get-job job-id)]
     (if (bg/kill-job! job-id)
-      (tools.util/single-text-content (str "Background job " job-id " killed."))
+      (tools.util/single-text-content (str "Background job " (job-prefix job) " killed."))
       (let [current-status (:status (bg/get-job job-id))]
         (tools.util/single-text-content
-         (str "Background job " job-id " is not running"
+         (str "Background job " (job-prefix job) " is not running"
               (when current-status (str " (status: " (name current-status) ")")) ".")
          true)))
     (tools.util/single-text-content (str "Background job " job-id " not found.") true)))
 
-;; ---------------------------------------------------------------------------
-;; Tool handler
-;; ---------------------------------------------------------------------------
-
 (defn ^:private bg-job [arguments _ctx]
   (let [action (get arguments "action")
         job-id (get arguments "job_id")]
@@ -68,10 +69,6 @@
                (tools.util/single-text-content "job_id is required for kill action." true))
       (tools.util/single-text-content (str "Unknown action: " action ". Use list, read_output, or kill.") true))))
 
-;; ---------------------------------------------------------------------------
-;; Tool definition
-;; ---------------------------------------------------------------------------
-
 (def definitions
   {"bg_job"
    {:description (tools.util/read-tool-description "bg_job")
@@ -84,10 +81,14 @@
                  :required ["action"]}
     :summary-fn (fn [{:keys [args]}]
                   (let [action (get args "action")
-                        job-id (get args "job_id")]
+                        job-id (get args "job_id")
+                        label (when job-id
+                                (if-let [job (bg/get-job job-id)]
+                                  (job-prefix job)
+                                  job-id))]
                     (case action
                       "list" "Listing background jobs"
-                      "read_output" (str "Reading output of " job-id)
-                      "kill" (str "Killing " job-id)
+                      "read_output" (str "Reading output of " label)
+                      "kill" (str "Killing " label)
                       "Managing background job")))
     :handler #'bg-job}})

test/eca/features/background_tasks_test.clj

@@ -254,6 +254,13 @@
         (let [result (handler {"action" "list"} {})]
           (is (match? {:error false
                        :contents [{:type :text :text #"job-\d+.*npm run dev"}]}
+                      result))))
+
+      (testing "list includes quoted job name when summary is set"
+        (bg/register-shell-job! {:label "npm test" :summary "dev-server" :process (mock-process) :working-directory "/tmp"})
+        (let [result (handler {"action" "list"} {})]
+          (is (match? {:error false
+                       :contents [{:type :text :text #"\"dev-server\" \(job-\d+\).*npm test"}]}
                       result)))))))
 
 (deftest bg-job-tool-read-output-test
@@ -276,6 +283,13 @@
                                           {:text "oops" :stream :stderr}] :total-lines 2})
           (is (match? {:error false
                        :contents [{:type :text :text #"hello\n\[stderr\] oops"}]}
+                      (handler {"action" "read_output" "job_id" (:id job)} {})))))
+
+      (testing "read_output header includes quoted job name when summary is set"
+        (let [job (bg/register-shell-job! {:label "test" :summary "my-job" :process (mock-process) :working-directory "/tmp"})]
+          (reset! (:output* job) {:lines [{:text "hi" :stream :stdout}] :total-lines 1})
+          (is (match? {:error false
+                       :contents [{:type :text :text #"Job \"my-job\" \(job-\d+\) — running"}]}
                       (handler {"action" "read_output" "job_id" (:id job)} {}))))))))
 
 (deftest bg-job-tool-kill-test
@@ -303,6 +317,19 @@
           (bg/kill-job! (:id job))
           (is (match? {:error true
                        :contents [{:type :text :text #"not running"}]}
+                      (handler {"action" "kill" "job_id" (:id job)} {})))))
+
+      (testing "kill running job with summary includes name in output"
+        (let [job (bg/register-shell-job! {:label "server3" :summary "my-server" :process (mock-process) :working-directory "/tmp"})]
+          (is (match? {:error false
+                       :contents [{:type :text :text #"Background job \"my-server\" \(job-\d+\) killed\."}]}
+                      (handler {"action" "kill" "job_id" (:id job)} {})))))
+
+      (testing "kill already-stopped job with summary"
+        (let [job (bg/register-shell-job! {:label "server4" :summary "another-server" :process (mock-process) :working-directory "/tmp"})]
+          (bg/kill-job! (:id job))
+          (is (match? {:error true
+                       :contents [{:type :text :text #"Background job \"another-server\" \(job-\d+\) is not running"}]}
                       (handler {"action" "kill" "job_id" (:id job)} {}))))))))
 
 (deftest bg-job-tool-unknown-action-test