Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not working with Typescript #101

Closed
taishi55 opened this issue Oct 5, 2022 · 12 comments
Closed

not working with Typescript #101

taishi55 opened this issue Oct 5, 2022 · 12 comments

Comments

@taishi55
Copy link

taishi55 commented Oct 5, 2022

I tried to use this plugin with typescript. It seems not working.

I look forward to hearing some advice.

So far, I tried npm i --save-dev @types/editorjs__embed and adding declare module '@editorjs/embed'; on external.d.ts

@taishi55 taishi55 changed the title Typescript Support Typescript not working Oct 5, 2022
@taishi55 taishi55 changed the title Typescript not working not working with Typescript Oct 5, 2022
@thmarx
Copy link

thmarx commented Dec 5, 2022

Same here!
In typescript the embed block is not shown in the menu.

@ludusrusso
Copy link

same here

@TheAlphamerc
Copy link

Same here

@legezam
Copy link

legezam commented Jan 11, 2023

same here

@legezam
Copy link

legezam commented Jan 11, 2023

Aah, it works it just doesn't have a UI. This issue can be closed.
If you want to trigger embed, go to youtube, and paste the url of a video from the address bar (not the embed code!) into a plain paragraph block and it will work automagically.
Perhaps it would be beneficial to make this a bit more clear in the readme or somewhere.

@TheAlphamerc
Copy link

Yeah, and having a UI would also be great.

@RedLionHeart
Copy link

RedLionHeart commented Feb 7, 2023

haha thanks for the comment. I would never have guessed.
and inline toolbar not working

@notaloop0000
Copy link

It does not work if the link includes the channel id. For example, https://www.youtube.com/watch?v=ypa_7HT2UGQ&ab_channel=NotaLoop

@kimyvgy
Copy link

kimyvgy commented Apr 27, 2023

Same here, Embed does not show in the menu.

@mohamedsahel
Copy link

Same here

@Sozialarchiv
Copy link
Contributor

Meanwhile it should work with typescript.

Same here, Embed does not show in the menu.

This is not a bug. It a feature. Just add the url in Paragraph.

@neSpecc
Copy link
Contributor

neSpecc commented Oct 12, 2024

Resolved by #128

@neSpecc neSpecc closed this as completed Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests