Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema: should "<<matchers>>" be specified in the schema? #4

Open
ffes opened this issue Nov 13, 2017 · 1 comment · May be fixed by #10
Open

Schema: should "<<matchers>>" be specified in the schema? #4

ffes opened this issue Nov 13, 2017 · 1 comment · May be fixed by #10
Labels
schema

Comments

@ffes
Copy link
Member

ffes commented Nov 13, 2017

I am not an expert in JSON schema's but I don't think that all the matchers should be specified in the schema. Starts at line 79 in editorconfig-defaults.schema.json
@deinok
Copy link

deinok commented Nov 16, 2017

Now "matches" is an object, probably it would be better to have it as an array.

@ffes ffes added the schema label Dec 14, 2017
@ffes ffes linked a pull request Dec 15, 2017 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
schema
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert objects to arrays ffes/editorconfig-defaults
2 participants
@ffes @deinok