Skip to content

Commit f497c7b

Browse files
Muhammad Faraz  MaqsoodMuhammad Faraz  Maqsood
Muhammad Faraz Maqsood
authored and
Muhammad Faraz Maqsood
committed
feat!: add badgr settings, make badges and courses independent incase of courses
1 parent c9890f3 commit f497c7b

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

lms/djangoapps/badges/events/course_complete.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -125,5 +125,4 @@ def course_badge_check(user, course_key):
125125
LOGGER.info("Completion badge already exists for this user on this course.")
126126
# Badge already exists. Skip.
127127
return
128-
evidence = evidence_url(user.id, course_key)
129-
badge_class.award(user, evidence_url=evidence)
128+
badge_class.award(user)

lms/djangoapps/certificates/models.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
from lms.djangoapps.badges.events.course_meta import completion_check, course_group_check
3131
from lms.djangoapps.certificates.data import CertificateStatuses
3232
from lms.djangoapps.instructor_task.models import InstructorTask
33-
from openedx.core.djangoapps.signals.signals import COURSE_CERT_AWARDED, COURSE_CERT_CHANGED, COURSE_CERT_REVOKED
33+
from openedx.core.djangoapps.signals.signals import COURSE_CERT_AWARDED, COURSE_CERT_CHANGED, COURSE_CERT_REVOKED, COURSE_GRADE_NOW_PASSED
3434
from openedx.core.djangoapps.xmodule_django.models import NoneToEmptyManager
3535
from openedx.features.name_affirmation_api.utils import get_name_affirmation_service
3636

@@ -1235,13 +1235,13 @@ class Meta:
12351235
app_label = "certificates"
12361236

12371237

1238-
@receiver(COURSE_CERT_AWARDED, sender=GeneratedCertificate)
1238+
@receiver(COURSE_GRADE_NOW_PASSED, dispatch_uid="new_passing_learner")
12391239
# pylint: disable=unused-argument
1240-
def create_course_badge(sender, user, course_key, status, **kwargs):
1240+
def create_course_badge(sender, user, course_id, **kwargs):
12411241
"""
12421242
Standard signal hook to create course badges when a certificate has been generated.
12431243
"""
1244-
course_badge_check(user, course_key)
1244+
course_badge_check(user, course_id)
12451245

12461246

12471247
@receiver(COURSE_CERT_AWARDED, sender=GeneratedCertificate)

0 commit comments

Comments
 (0)