Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type safety to the RecordFieldDictionary's type property --> backed by enum #13

Open
3 of 8 tasks
edorphy opened this issue Jan 11, 2022 · 0 comments
Open
3 of 8 tasks

Add type safety to the RecordFieldDictionary's type property --> backed by enum #13

edorphy opened this issue Jan 11, 2022 · 0 comments
Assignees
@edorphy
Labels
enhancement New feature or request tech debt
Milestone
Public Database F...

Comments

@edorphy
Copy link
Owner

edorphy commented Jan 11, 2022 •
edited
Loading

To improve type safety of the RecordFieldDictionary, make the 'type' property an enum

  • Make enum
  • Update decoding
  • Update encoding

Support for additional types:

  • Handle "UNKNOWN_LIST" FB9825479
  • BYTES
  • BYTES_LIST

Test Coverage of RecordFieldDictionary:

  • Single item types
  • List item types
@edorphy edorphy added enhancement New feature or request tech debt labels Jan 11, 2022
@edorphy edorphy self-assigned this Jan 11, 2022
edorphy added a commit that referenced this issue Jan 11, 2022
@edorphy
#13 - Created a type-safe enum for the RecordFieldDictionary's type p…
b187efb 
…roperty

- Updated decode method
- Added test coverage for singular field types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edorphy edorphy

Labels
enhancement New feature or request tech debt
Projects
None yet
Milestone
Public Database Fetch + Query Support
Development

No branches or pull requests
1 participant
@edorphy