-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update or replace jsonfield #42
Comments
I saw that someone was trying to run tests for this package with Django 3.2 and the tests failed. I think I can correct it or find another alternative. I will be working on this. |
@MaferMazu Thank you for reaching out, I highly appreciate your interest and help with this. I have assigned this task to you. Please feel free to open a PR once you are ready, I will take care of it from there on. |
I think the jsonfield library supports django 3.2, the only thing missing is that the author approves some PRs to add the corresponding tests. I already wrote to the author and the maintainer and created an issue rpkilby/jsonfield#264 I took the tests that are in the PRs |
@MaferMazu Thank you, I hope you hear back from them soon. Please keep us posted here. |
jsonfield allows to use JSONField but |
We'll shortly have a few other usages of this package as we migrate over from jsonfield2 as explained in #34 . And it would be tricky to jump directly to Django 3.1+ JSONField as I noted in #34 (comment) . |
This issue would be resolved equal to #34 which is already closed. |
Agreed, closing it as we have an upgrade path now. Thanks for helping sort this out! Tl;dr for those following up on this issue later: we believe the latest PyPI release of jsonfield should work with Django 3.2. |
We use the package jsonfield in edx/course-discovery. It hasn't yet added support for Django3.2. Please follow the guidance in https://openedx.atlassian.net/wiki/spaces/AC/pages/3036972032/Handling+Outdated+Dependencies to resolve the problem this poses for the Open edX Django 3.2 upgrade.
The text was updated successfully, but these errors were encountered: