Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update or replace jsonfield #42

Closed
Jawayria opened this issue Jul 27, 2021 · 8 comments
Closed

Update or replace jsonfield #42

Jawayria opened this issue Jul 27, 2021 · 8 comments
Assignees
Labels
outdated dependency A dependency needs to be updated or replaced to support an upgrade initiative

Comments

@Jawayria
Copy link

We use the package jsonfield in edx/course-discovery. It hasn't yet added support for Django3.2. Please follow the guidance in https://openedx.atlassian.net/wiki/spaces/AC/pages/3036972032/Handling+Outdated+Dependencies to resolve the problem this poses for the Open edX Django 3.2 upgrade.

@Jawayria Jawayria added the outdated dependency A dependency needs to be updated or replaced to support an upgrade initiative label Jul 27, 2021
@MaferMazu
Copy link

I saw that someone was trying to run tests for this package with Django 3.2 and the tests failed. I think I can correct it or find another alternative. I will be working on this.

@natabene
Copy link

natabene commented Aug 4, 2021

@MaferMazu Thank you for reaching out, I highly appreciate your interest and help with this. I have assigned this task to you. Please feel free to open a PR once you are ready, I will take care of it from there on.

@MaferMazu
Copy link

MaferMazu commented Aug 11, 2021

I think the jsonfield library supports django 3.2, the only thing missing is that the author approves some PRs to add the corresponding tests. I already wrote to the author and the maintainer and created an issue rpkilby/jsonfield#264

I took the tests that are in the PRs
Test: https://app.circleci.com/pipelines/github/MaferMazu/jsonfield?branch=mfmz%2Ffix-ci-and-test-django3.2

@natabene
Copy link

@MaferMazu Thank you, I hope you hear back from them soon. Please keep us posted here.

@MaferMazu
Copy link

jsonfield allows to use JSONField but Django>=3.1 includes JSONField (models.JSONField and forms.JSONField)
https://docs.djangoproject.com/en/3.2/releases/3.1/#jsonfield-for-all-supported-database-backends
and in edx/course-discovery jsonfield is only used in the requirements, so I think this package could be removed.

@jmbowman
Copy link

We'll shortly have a few other usages of this package as we migrate over from jsonfield2 as explained in #34 . And it would be tricky to jump directly to Django 3.1+ JSONField as I noted in #34 (comment) .

@MaferMazu
Copy link

This issue would be resolved equal to #34 which is already closed.

@jmbowman
Copy link

Agreed, closing it as we have an upgrade path now. Thanks for helping sort this out! Tl;dr for those following up on this issue later: we believe the latest PyPI release of jsonfield should work with Django 3.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outdated dependency A dependency needs to be updated or replaced to support an upgrade initiative
Projects
None yet
Development

No branches or pull requests

4 participants