Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule: no-restore #118

Open
igorkamyshev opened this issue Aug 29, 2022 · 1 comment
Open

Rule: no-restore #118

igorkamyshev opened this issue Aug 29, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers preset:strict

Comments

@igorkamyshev
Copy link
Member

Personally, I hate restore because of the following pattern 👇

const $currency = restore(currencyInited, null).on(settingsChanges, (_, { ccurency}) => currency);

Furthermore, I doubt that one line of code is a good reason to skip the full store declaration.
@igorkamyshev igorkamyshev added enhancement New feature or request good first issue Good for newcomers labels Aug 29, 2022
@sergeysova
Copy link
Member

I think this rule would be nice to add to a strict preset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers preset:strict
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sergeysova @igorkamyshev