Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add aop runtime/dynamic inject runtime for standalone #149

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

killagu
Copy link
Contributor

@killagu killagu commented Aug 29, 2023

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@killagu
Copy link
Contributor Author

killagu commented Aug 29, 2023

还差一个 eventbus,暂时先不加。异步对于 standalone 来说不友好,cli/serverless 可能很快退出,无法保障业务稳定。

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 97.22% and project coverage change: +0.02% 🎉

Comparison is base (f049412) 93.79% compared to head (582416e) 93.81%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
+ Coverage   93.79%   93.81%   +0.02%     
==========================================
  Files         228      229       +1     
  Lines        4815     4851      +36     
  Branches      526      532       +6     
==========================================
+ Hits         4516     4551      +35     
- Misses        299      300       +1     
Files Changed Coverage Δ
...ndalone/standalone/src/ConfigSourceLoadUnitHook.ts 100.00% <ø> (ø)
core/runtime/src/factory/EggContainerFactory.ts 93.33% <83.33%> (-2.50%) ⬇️
...tandalone/standalone/src/LoadUnitInnerClassHook.ts 100.00% <100.00%> (ø)
standalone/standalone/src/Runner.ts 93.13% <100.00%> (+1.67%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@killagu killagu added this pull request to the merge queue Aug 29, 2023
Merged via the queue into master with commit 6091fc6 Aug 29, 2023
17 checks passed
@killagu killagu deleted the feat/standalone_features branch August 29, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants