hilbert is a mess #341
eggrobinlint.yaml
on: push
check-remove-before-flight
16s
check-cpp
1m 51s
check-iwyu
2m 15s
Annotations
2 errors and 9 warnings
|
check-cpp
Process completed with exit code 1.
|
|
check-iwyu
Process completed with exit code 1.
|
|
check-remove-before-flight
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
check-cpp
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
whitespace/braces:
quantities/concepts.hpp#L17
Missing space before {
|
|
whitespace/ending_newline:
quantities/concepts.hpp#L26
Could not find a newline character at the end of the file.
|
|
check-iwyu
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Include what you using:
geometry/r3_element.hpp#L1
include_what_you_using_all_the_things.ps1 modifies this file as follows:
diff --git a/geometry/r3_element.hpp b/geometry/r3_element.hpp
index 7f6d62b..17606e7 100644
--- a/geometry/r3_element.hpp
+++ b/geometry/r3_element.hpp
@@ -19,9 +19,9 @@ namespace internal {
using namespace principia::base::_not_null;
using namespace principia::base::_tags;
+using namespace principia::quantities::_concepts;
using namespace principia::quantities::_named_quantities;
using namespace principia::quantities::_quantities;
-using namespace principia::quantities::_concepts;
template<typename Scalar>
struct SphericalCoordinates;
|
|
Include what you using:
numerics/double_precision_body.hpp#L1
include_what_you_using_all_the_things.ps1 modifies this file as follows:
diff --git a/numerics/double_precision_body.hpp b/numerics/double_precision_body.hpp
index 1ff5311..271706b 100644
--- a/numerics/double_precision_body.hpp
+++ b/numerics/double_precision_body.hpp
@@ -30,9 +30,9 @@ using namespace principia::geometry::_point;
using namespace principia::geometry::_r3_element;
using namespace principia::geometry::_serialization;
using namespace principia::numerics::_fma;
+using namespace principia::quantities::_concepts;
using namespace principia::quantities::_elementary_functions;
using namespace principia::quantities::_si;
-using namespace principia::quantities::_concepts;
// A helper to check that the preconditions of QuickTwoSum are met. Annoyingly
// complicated as it needs to peel off all of our abstractions until it reaches
|
|
Include what you using:
quantities/concepts.hpp#L1
include_what_you_using_all_the_things.ps1 modifies this file as follows:
diff --git a/quantities/concepts.hpp b/quantities/concepts.hpp
index 7991bd8..ef4b0e0 100644
--- a/quantities/concepts.hpp
+++ b/quantities/concepts.hpp
@@ -23,4 +23,4 @@ using internal::quantity;
} // namespace _concepts
} // namespace quantities
-} // namespace principia
\ No newline at end of file
+} // namespace principia
|
|
Include what you using:
quantities/concepts_test.cpp#L1
include_what_you_using_all_the_things.ps1 modifies this file as follows:
diff --git a/quantities/concepts_test.cpp b/quantities/concepts_test.cpp
index 066cffe..b152ae7 100644
--- a/quantities/concepts_test.cpp
+++ b/quantities/concepts_test.cpp
@@ -6,8 +6,8 @@
namespace principia {
namespace quantities {
-using namespace principia::quantities::_named_quantities;
using namespace principia::quantities::_concepts;
+using namespace principia::quantities::_named_quantities;
TEST(Traits, IsQuantityV) {
static_assert(quantity<int>);
|