Skip to content

remove geometry traits #350

remove geometry traits

remove geometry traits #350

Triggered via push March 23, 2024 14:55
Status Failure
Total duration 2m 3s
Artifacts

lint.yaml

on: push
check-remove-before-flight
14s
check-remove-before-flight
check-cpp
1m 52s
check-cpp
check-iwyu
1m 26s
check-iwyu
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 7 warnings
check-iwyu
Process completed with exit code 1.
check-cpp
Process completed with exit code 1.
check-remove-before-flight
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
check-iwyu
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Include what you using: numerics/polynomial_in_monomial_basis.hpp#L1
include_what_you_using_all_the_things.ps1 modifies this file as follows: diff --git a/numerics/polynomial_in_monomial_basis.hpp b/numerics/polynomial_in_monomial_basis.hpp index 64ba9c1..fbc310f 100644 --- a/numerics/polynomial_in_monomial_basis.hpp +++ b/numerics/polynomial_in_monomial_basis.hpp @@ -18,6 +18,7 @@ #include "base/traits.hpp" #include "geometry/hilbert.hpp" #include "geometry/point.hpp" +#include "quantities/concepts.hpp" #include "quantities/named_quantities.hpp" #include "quantities/tuples.hpp" #include "serialization/numerics.pb.h"
Include what you using: quantities/concepts_test.cpp#L1
include_what_you_using_all_the_things.ps1 modifies this file as follows: diff --git a/quantities/concepts_test.cpp b/quantities/concepts_test.cpp index 43c723f..e6815c4 100644 --- a/quantities/concepts_test.cpp +++ b/quantities/concepts_test.cpp @@ -2,6 +2,7 @@ #include "gtest/gtest.h" #include "quantities/named_quantities.hpp" +#include "quantities/quantities.hpp" namespace principia { namespace quantities {
check-cpp
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
whitespace/braces: numerics/polynomial_in_monomial_basis_body.hpp#L441
{ should almost always be at the end of the previous line
whitespace/braces: numerics/polynomial_in_monomial_basis_body.hpp#L457
{ should almost always be at the end of the previous line