-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Watch mode not working on v8.3.4 / v8.3.5 #1245
Comments
it might be, due to recent upgrade of Chokidar to v4 in PR #1211. Perhaps the new |
could be, would have to check how chokidar v3 did globbing |
I'm having the same issue. I had version When I run the project I do not see the typical watch mode message, which looks something like:
The project does not reload on changes. However! If I stop my Express server from running: // stop express server from running
// server.listen(8080, () => console.log('Server is live')) Removing this line of code and restarting my app, I see the expected watch mode message and my project does reload on changes. Downgrading to |
I'm encountering the same issue, but it seems the When I run |
I've reviewed the source and I think I've found the cause. I added a bunch of log statements to the JS files in the node_modules dist folder and I found that there's a point where the code no longer progresses. I'm pretty sure it's related to this line: https://github.com/egoist/tsup/blame/cd03e1e00ec2bd6676ae1837cbc7e618ab6a2362/src/index.ts#L357 Which, ultimately was updated with this PR which lines up with the timeframe for the last 2 versions not working correctly: 4dd5bfe If I comment this line out in my dist folder (which, unfortunately, is elsewhere, because it's been transpiled), watch runs as normal. I will provide a PR soon as a band-aid solution. Even if it's NOT the solution, it would behoove us to figure out what that goal is for the await statement, considering it breaks the functionality as listed in the documentation |
PR: #1253 |
almost a month with no fix 😭 is there a better tsup alternative? |
Just use Esbuild. Tsup is just a wrapper around it. |
Oh wow, I didn't know that. Thanks! |
@ocavue Any chance we can get some eyes on the PR above? |
Yeah, this issue is major headache. Personally, I'd like to see chokidar swapped out for https://github.com/parcel-bundler/watcher. Chokidar v4 has been a hassle.
Not really. tsup does post-processing similarly to vite, wherein treeshaking is performed by rollup and swc exists at some-point. There are also various features that help alleviate pain-points when writing modern tooling, esp node tooling. (see #806 for more on that). I'll have a look at a PR. |
It works until v8.3.0 but doesn't work on next releases v8.3.4 and v8.3.5.
v.8.3.0
There are two lines at the bottom and watch mode works well.
v8.3.4 / v8.3.5
No messages for watch mode and watch mode doesn't work as well.
Upvote & Fund
The text was updated successfully, but these errors were encountered: