diff --git a/.github/workflows/upload-to-codacy.yml b/.github/workflows/upload-to-codacy.yml index a9a9411a..321acc13 100644 --- a/.github/workflows/upload-to-codacy.yml +++ b/.github/workflows/upload-to-codacy.yml @@ -11,9 +11,20 @@ jobs: strategy: fail-fast: true name: upload-coverage + steps: + - name: Setup logs directory + run: mkdir -p build/coverage + + - name: Download clover.xml artifact + uses: actions/download-artifact@v3 + with: + name: clover.xml + path: build/coverage + - name: Upload Coverage to Codacy shell: bash env: CODACY_PROJECT_TOKEN: ${{ secrets.CODACY_PROJECT_TOKEN }} - run: bash <(curl -Ls https://coverage.codacy.com/get.sh) report -r build/logs/clover.xml \ No newline at end of file + + run: bash <(curl -Ls https://coverage.codacy.com/get.sh) report -r build/coverage/clover.xml \ No newline at end of file diff --git a/README.md b/README.md index 1d61f604..eed19d00 100644 --- a/README.md +++ b/README.md @@ -34,7 +34,7 @@ This library aims to support RFCs: * [Spoofchecking](/src/Validation/Extra/SpoofCheckValidation.php) and [DNSCheckValidation](/src/Validation/DNSCheckValidation.php) validation requires that your PHP system has the -[PHP Internationalization Libraries](https://php.net/manual/en/book.intl.php) +[PHP Internationalization Libraries](https://php.net/manual/en/book.intl.php) (also known as PHP Intl) **Note**: `PHP version upgrades will happen to accomodate to the pace of major @@ -109,7 +109,6 @@ Validations not present in the RFCs 1. [SpoofCheckValidation](/src/Validation/Extra/SpoofCheckValidation.php): Will check for multi-utf-8 chars that can signal an erroneous email name. - ### How to extend It's easy! You just need to implement @@ -126,7 +125,8 @@ Is short and simple and will help a lot. (You can find current contributors [here](https://github.com/egulias/EmailValidator/graphs/contributors)) -As this is a port from another library and work, here are other people related to the previous one: +As this is a port from another library and work, here are other people related +to the previous one: * Ricard Clau [@ricardclau](https://github.com/ricardclau): Performance against PHP built-in filter_var (v2 and earlier) diff --git a/src/Result/Result.php b/src/Result/Result.php index fd13e6c6..0e50fc51 100644 --- a/src/Result/Result.php +++ b/src/Result/Result.php @@ -6,22 +6,26 @@ interface Result { /** * Is validation result valid? + * */ - public function isValid() : bool; + public function isValid(): bool; /** * Is validation result invalid? * Usually the inverse of isValid() + * */ - public function isInvalid() : bool; + public function isInvalid(): bool; /** * Short description of the result, human readable. + * */ - public function description() : string; + public function description(): string; /** * Code for user land to act upon. + * */ - public function code() : int; + public function code(): int; }