Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change forward Hcal insert's readout to a hexagonal grid #496

Closed
rymilton opened this issue Aug 10, 2023 · 11 comments · Fixed by #497
Closed

Change forward Hcal insert's readout to a hexagonal grid #496

rymilton opened this issue Aug 10, 2023 · 11 comments · Fixed by #497
Assignees
@rymilton
Labels
enhancement New feature or request topic: calorimetry topic: forward Positive-rapidity detectors (hadron-going side)

Comments

@rymilton
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The forward HCal insert currently uses a square segmentation (CartesianGridXY) but should actually use a hexagonal grid segmentation.

Describe the solution you'd like
Create a hexagonal grid segmentation class and push it to ePIC. It would be similar to CartesianGridXY but would use hexagons instead of squares.

Describe alternatives you've considered
Push the segmentation class to the official DD4hep repository instead of to ePIC.

Additional context
The hexagon readout class currently does not exist in DDCore.
@rymilton rymilton self-assigned this Aug 10, 2023
@rymilton rymilton added enhancement New feature or request topic: forward Positive-rapidity detectors (hadron-going side) topic: calorimetry question labels Aug 10, 2023
@rymilton
Copy link
Contributor Author

Any input on where to push the files? If in the epic repository, should I put it somewhere specific to separate it from the detector files?

@rymilton rymilton mentioned this issue Aug 10, 2023
Merged
7 tasks
@wdconinc
Copy link
Contributor

This should really go into DD4hep, not ePIC. It is generally applicable.

@rymilton
Copy link
Contributor Author

Sure, I'll try doing that. I've never made changes to DD4hep before so I might need some help but I'll ask about that in the Helpdesk channel.

@rymilton
Copy link
Contributor Author

Changing issue to adjusting the readout style of the insert, rather than implementing the segmentation class.

@rymilton rymilton reopened this Aug 10, 2023
@rymilton rymilton changed the title Implement hexagonal segmentation class for forward HCal insert Change forward Hcal insert's readout to a hexagonal grid Aug 10, 2023
@rymilton rymilton removed the question label Aug 10, 2023
@rymilton
Copy link
Contributor Author

Dependent on the creation of the hexagonal grid segmentation class in DD4hep. This completion of this issue is blocked until then.

@veprbl
Copy link
Member

veprbl commented Aug 10, 2023

It is probably a good idea to just implement hexagonal tiles as volumes. Segmentations in DD4hep are well applicable to fine grids or preliminary designs. Design of the forward insert is already very mature. The only tricky part with volumes is that you'd need to use binary operations on volumes to create truncated tiles for the edges.

@veprbl
Copy link
Member

veprbl commented Aug 25, 2023

Upstream PR AIDASoft/DD4hep#1161

@Chao1009 Chao1009 moved this from Todo to Blocked in ePIC Software and Computing Sep 6, 2023
@wdconinc
Copy link
Contributor

Hexagonal (and staggered cartesian) grids are now in eic-shell:

jug_xl> wdconinc@menelaos:~/git/epic$ ls /usr/local/include/DDSegmentation/HexGrid.h 
/usr/local/include/DDSegmentation/HexGrid.h

Thanks to @sebouh137 for the upstream contribution.

@rymilton
Copy link
Contributor Author

rymilton commented Oct 4, 2023

Apologies for the delay on this. Working on implementing it now.

Additionally, the latest insert design has 10 tungsten layers instead of the 4 that are currently in the simulation, so I'll correct this.

@rymilton rymilton changed the title Change forward Hcal insert's readout to a hexagonal grid Change forward Hcal insert's readout to a hexagonal grid and increase number of W/Sc layers to 10 Oct 4, 2023
@rymilton rymilton moved this from Blocked to In Progress in ePIC Software and Computing Oct 4, 2023
@rymilton rymilton linked a pull request Oct 4, 2023 that will close this issue
feat: Make Hcal insert's readout a hexagonal grid #497
Merged
7 tasks
@wdconinc
Copy link
Contributor

wdconinc commented Oct 5, 2023

Feel free to make two PRs so they can be reviewed independently.

@rymilton
Copy link
Contributor Author

rymilton commented Oct 5, 2023

Layer numbering changed to Issue #546 .

@rymilton rymilton changed the title Change forward Hcal insert's readout to a hexagonal grid and increase number of W/Sc layers to 10 Change forward Hcal insert's readout to a hexagonal grid Oct 5, 2023
github-merge-queue bot pushed a commit that referenced this issue Oct 10, 2023
@rymilton
feat: Make Hcal insert's readout a hexagonal grid (#497)
7e4ddb2 
### Briefly, what does this PR introduce?
Change the forward Hcal insert's readout to a hexagonal grid with
hexagons of side size 1.889 cm and staggering between the layers. Test
data was generated and it ran smoothly through EICrecon.

### What kind of change does this PR introduce?
- [ ] Bug fix (issue #__)
- [X] New feature (issue #496 )
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [X] Documentation has been added / updated
- [X] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No breaking changes, no changes needed.
### Does this PR change default behavior?
Only changes the default readout of the insert.
@github-project-automation github-project-automation bot moved this from In Progress to Done in ePIC Software and Computing Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rymilton rymilton

Labels
enhancement New feature or request topic: calorimetry topic: forward Positive-rapidity detectors (hadron-going side)
Projects
ePIC Software and Computing
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Make Hcal insert's readout a hexagonal grid eic/epic
3 participants
@veprbl @wdconinc @rymilton