Too many open files

[Knaldgas]

I get Too many open files running sig make-all -r -i /var/www/gallery/albums/ on my gallery.
My ulimits is set to 1024 files, which I think should be enough for most tasks.

Perhaps sig forgets to close files after use?

Creating gallery from images in /var/www/gallery/albums/
.............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................Backtrace:
In ice-9/boot-9.scm:
   222:29 19 (map1 _)
   222:29 18 (map1 _)
   222:29 17 (map1 _)
   222:29 16 (map1 _)
   222:29 15 (map1 _)
   222:29 14 (map1 _)
   222:29 13 (map1 _)
   222:29 12 (map1 _)
   222:29 11 (map1 _)
   222:29 10 (map1 _)
   222:29  9 (map1 _)
   222:29  8 (map1 _)
   222:17  7 (map1 ("/var/www/gallery/albums//2010jan…" …))
In unknown file:
           6 (_ #<procedure 7febcffaef40 at ice-9/boot-9.scm:792:28…> …)
In ice-9/eval.scm:
   293:34  5 (_ #(#(#(#<directory (guile-user) 7febd11eef00> …) #) #))
   293:34  4 (_ #(#(#(#(#(#(#<directory (guile-user)…>) …) …) …) …) …))
   293:34  3 (_ #(#(#(#(#(#(#<directory (guile-user)…>) …) …) …) …) …))
In ice-9/popen.scm:
   133:22  2 (open-pipe* "r" _ . _)
   112:20  1 (open-process "r" "/bin/sh" "-c" "LC_ALL=C jhead -q /va…")
In unknown file:
           0 (pipe)

ERROR: In procedure pipe:
In procedure pipe: Too many open files

[eikek]

Thanks for letting me know! I don't know right now, haven't looked into it for a while. How many files do you have that triggers this? I'll see where I missed to close files or processes.

[Knaldgas]

4300 images;
After I raised the file limit and let the script complete, I see that the script does not generate sub-albums, in which case a limit of ~1000 files in itself is not an issue, but perhaps something that should be fixed anyhow?!

[eikek]

I'm afraid I don't understand your last comment. What do you mean by "sub-albums"?

[eikek]

I'm afraid I don't understand your last comment. What do you mean by "sub-albums"?

[Knaldgas]

I guess it was a bit cryptic, sorry!
My pictures are placed in a directory-tree, separate folders for each album. An album is collection of related images (e.g. summerholiday 2020, and the sorts). I asked sig to process recursively from the root of that directory tree and expected (wrongly I presume) to see it make a hierarchical media gallery in html.
If sig takes all media given to be placed into the same gallery, then the current limit on ~1000 media files is not a problem - You would likely not want to have more on the same page anyway :)

[eikek]

Ah I see, thanks for clarifying! (No idea, why my previous comment shows up twice…).

You're right, it wouldn't probably make much sense to have 1000+ images on one page. But it is something that should be fixed, as you said. And this is all very basic stuff, it doesn't recognize folders as albums (I see that it would be nice…).